Skip to content

[cherry-pick][release-v0.17] fix(llmisvc): remove ibm-aiu-setup.sh sourcing from base template (#1200)#1203

Closed
KillianGolds wants to merge 1 commit intoopendatahub-io:release-v0.17from
KillianGolds:cherry-pick/release-v0.17/1200
Closed

[cherry-pick][release-v0.17] fix(llmisvc): remove ibm-aiu-setup.sh sourcing from base template (#1200)#1203
KillianGolds wants to merge 1 commit intoopendatahub-io:release-v0.17from
KillianGolds:cherry-pick/release-v0.17/1200

Conversation

@KillianGolds
Copy link
Copy Markdown

Body

Cherry-pick of #1200

What this PR does / why we need it

Removes the ibm-aiu-setup.sh conditional sourcing from the base llmisvc template. This logic belongs in the accelerator-specific Spyre configs, not the base template. Already merged on midstream master.

Conflicts resolved

None, clean cherry-pick.

Dependencies

Must be merged before the cherry-pick of kserve#5154 (feat(llmisvc): add --disable-uvicorn-access-log to vllm configs), which is rebased on top of this change.

…template (opendatahub-io#1200)

IBM Spyre team has removed /etc/profile.d/ibm-aiu-setup.sh from their
images, making the conditional sourcing dead code. Remove it from the
bash wrapper while preserving the  args forwarding pattern from
kserve#5049.

Signed-off-by: Killian Golds <kgolds@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KillianGolds
Once this PR has been reviewed and has the lgtm label, please assign brettmthompson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d1fc4fcf-8386-4d3b-8c2f-e30d88b9e949

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pierDipi pierDipi closed this Mar 16, 2026
@github-project-automation github-project-automation bot moved this from New/Backlog to Done in ODH Model Serving Planning Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants