[cherry-pick][release-v0.17] fix(llmisvc): remove ibm-aiu-setup.sh sourcing from base template (#1200)#1203
Conversation
…template (opendatahub-io#1200) IBM Spyre team has removed /etc/profile.d/ibm-aiu-setup.sh from their images, making the conditional sourcing dead code. Remove it from the bash wrapper while preserving the args forwarding pattern from kserve#5049. Signed-off-by: Killian Golds <kgolds@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KillianGolds The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Body
Cherry-pick of #1200
What this PR does / why we need it
Removes the
ibm-aiu-setup.shconditional sourcing from the base llmisvc template. This logic belongs in the accelerator-specific Spyre configs, not the base template. Already merged on midstream master.Conflicts resolved
None, clean cherry-pick.
Dependencies
Must be merged before the cherry-pick of kserve#5154 (
feat(llmisvc): add --disable-uvicorn-access-log to vllm configs), which is rebased on top of this change.