Skip to content

18: update Python license file#11

Closed
sundararajana wants to merge 2 commits into
openjdk:masterfrom
sundararajana:DETROIT-18
Closed

18: update Python license file#11
sundararajana wants to merge 2 commits into
openjdk:masterfrom
sundararajana:DETROIT-18

Conversation

@sundararajana

@sundararajana sundararajana commented Jun 10, 2026

Copy link
Copy Markdown
Member

Python license file has to be moved under ./legal/Python and it should be a .md file with changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Warning

 ⚠️ Found leading lowercase letter in issue title for 18: update Python license file

Issue

  • DETROIT-18: update Python license file (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/detroit-python.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/detroit-python.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/detroit-python/pull/11.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 10, 2026

Copy link
Copy Markdown

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@MegJayan

MegJayan commented Jun 10, 2026

Copy link
Copy Markdown

Looks good, Thanks Sundar

@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

@sundararajana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

18: update Python license file

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 10, 2026
@arvindaprameya

arvindaprameya commented Jun 10, 2026

Copy link
Copy Markdown

LGTM, thanks for making this change

@mlbridge

mlbridge Bot commented Jun 10, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 10, 2026
@sundararajana

Copy link
Copy Markdown
Member Author

/integrate

@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

Going to push as commit a7bc6d1.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jun 10, 2026
@openjdk openjdk Bot closed this Jun 10, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2026
@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

@sundararajana Pushed as commit a7bc6d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants