USHIFT-6712: Skip release block in run_bootc_image_build() microshift CI jobs#6382
USHIFT-6712: Skip release block in run_bootc_image_build() microshift CI jobs#6382agullon wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe CI script Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
agullon
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@agullon: This pull request references USHIFT-6712 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-release |
| if [[ "${CI_JOB_NAME}" =~ .*release(-arm)?(-el[0-9]+)?$ ]]; then | ||
| $(dry_run) bash -x ./bin/build_bootc_images.sh -X | ||
| return | ||
| fi |
There was a problem hiding this comment.
Also, why do we need such a complex regex?
There was a problem hiding this comment.
what block to you mean? the link redirects me to this comment
There was a problem hiding this comment.
About the regexp, I modify it a little bit to improve readability but I think it's good as it is, see this for better understanding: https://regex101.com/r/VivrQ3/2
There was a problem hiding this comment.
The regexp is good, but it's more complex than required. All other places we use a simpler .*release.* expression, which should be good here as well, right?
There was a problem hiding this comment.
For the lines of code, I mean lines 141-143 (before the change) or 146-148 after.
agullon
force-pushed
the
fix/restore-release-skip-bootc-build
branch
from
9698a51 to
6bb36b6
Compare
pre-commit.check-secrets: ENABLED
agullon
force-pushed
the
fix/restore-release-skip-bootc-build
branch
from
6bb36b6 to
7b0726d
Compare
|
@agullon: This pull request references USHIFT-6712 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-release |
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
run_bootc_image_build()that was accidentally removed by PR USHIFT-6547: Add RHEL 10 CI lane #6330 (USHIFT-6547: Add RHEL 10 CI lane).build_bootc_images.sh -Xto extract container images.(-el(9|10)?to match the new OS-suffixed bootc job names (e.g.*-release-el9,*-release-el10).Ref: #6330 (comment)
Original implementation: #6149