Skip to content

Conversation

@mburke5678
Copy link
Contributor

https://issues.redhat.com/browse/OSDOCS-17429

The autoSizingReserved parameter is now set to true in 4.21+. This PR removes the Automatically allocating resources for nodes module, which shows how to set this parameter to true, as it is no longer needed.

I updated Manually allocating resources for nodes to require the autoSizingReserved: false parameter. Also, I brought some of the text from Automatially allocating (with some slight changes) and the verification from Automatically allocating to this module (unchanged except for the example output).

Link to docs preview:

QE review:

  • QE has approved this change.

@mburke5678 mburke5678 added this to the Planned for 4.21 GA milestone Dec 12, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 12, 2025

@mburke5678
Copy link
Contributor Author

@ngopalak-redhat PTAL

@ngopalak-redhat
Copy link

/hold
Discussing an issue here: https://redhat-internal.slack.com/archives/C0A2C81N2H3/p1765460629049379 with the code change.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2025
@mburke5678
Copy link
Contributor Author

@ngopalak-redhat Any updates on the issue you mentioned earlier?

@ngopalak-redhat
Copy link

@mburke5678 I'll provide an update on Monday. Today the change is added back to 4.21 release. I'd like to give it a few days.

@ngopalak-redhat
Copy link

@mburke5678 We need to use content from here: https://access.redhat.com/solutions/5843241 into the docs.

@ngopalak-redhat
Copy link

@mburke5678 I’ve reviewed the draft regarding node resource allocation. Overall, it looks good, but I have a few specific adjustments to align with the implementation details:

  • kube-reserved clarification: I took a closer look at the kube-reserved row in the table. As you noted, it is best to remove this row entirely from the table to avoid confusion. Instead, we should add a standalone note stating that kube-reserved is not utilized in OpenShift.
  • system-reserved definition: For the system-reserved description, please specify that this setting applies to all processes that use the system.slice cgroup
  • Remove unused flag references: We should remove the lines starting with "If a flag is not set...". This page does not discuss specific command-line flags, so this phrasing might be confusing to the reader.
  • Script timing: After the sentence describing the script that determines optimal resources, please add: "The script runs during the startup of the node."
  • Please update the phrase "automatic resource allocation is disabled by default" to "automatic resource allocation of system resources is disabled by default" for better technical accuracy.
  • Worker-only scope: Please remove the reference to 50-master-auto-sizing-disabled. We ultimately landed this feature for worker nodes only.
  • External linking: After the line mentioning where the node summary is available, please add a link to the upstream Kubernetes Node Metrics data documentation: https://kubernetes.io/docs/reference/instrumentation/node-metrics/
  • explicitly state that 1000m = 1 vCPU early in the text to assist users who are less familiar with the conversion
  • There was an incident where a customer put "autoSizingReserved" inside the "kubeletconfig", can you add a note that "autoSizingReserved" is an openshift feature and that it should be specified as given in the example.

@mburke5678
Copy link
Contributor Author

@ngopalak-redhat

"The script runs during the startup of the node."
Do you mean that the script applies only to new nodes?

I am not sure what this means:
There was an incident where a customer put "autoSizingReserved" inside the "kubeletconfig", can you add a note that "autoSizingReserved" is an openshift feature and that it should be specified as given in the example.

The first four bullets we can address in a separate PR so that we can roll the changes back to earlier OCP versions.

////
[role="_additional-resources"]
id="nodes-nodes-resources-configuring_additional-resources"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.RelatedLinks: Content other than links cannot be mapped to DITA related-links.

////
[role="_additional-resources"]
id="nodes-nodes-resources-configuring_additional-resources"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.AssemblyContents: Content other than additional resources cannot follow include directives.

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ngopalak-redhat
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.21 do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants