-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS 17429 AutoSizingReserved is enabled by default #103868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OSDOCS 17429 AutoSizingReserved is enabled by default #103868
Conversation
|
🤖 Fri Jan 16 13:15:37 - Prow CI generated the docs preview: https://103868--ocpdocs-pr.netlify.app/ |
|
@ngopalak-redhat PTAL |
|
/hold |
|
@ngopalak-redhat Any updates on the issue you mentioned earlier? |
|
@mburke5678 I'll provide an update on Monday. Today the change is added back to 4.21 release. I'd like to give it a few days. |
|
@mburke5678 We need to use content from here: https://access.redhat.com/solutions/5843241 into the docs. |
|
@mburke5678 I’ve reviewed the draft regarding node resource allocation. Overall, it looks good, but I have a few specific adjustments to align with the implementation details:
|
I am not sure what this means: The first four bullets we can address in a separate PR so that we can roll the changes back to earlier OCP versions. |
| //// | ||
| [role="_additional-resources"] | ||
| id="nodes-nodes-resources-configuring_additional-resources"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.RelatedLinks: Content other than links cannot be mapped to DITA related-links.
| //// | ||
| [role="_additional-resources"] | ||
| id="nodes-nodes-resources-configuring_additional-resources"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.AssemblyContents: Content other than additional resources cannot follow include directives.
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
https://issues.redhat.com/browse/OSDOCS-17429
The
autoSizingReservedparameter is now set totruein 4.21+. This PR removes the Automatically allocating resources for nodes module, which shows how to set this parameter totrue, as it is no longer needed.I updated Manually allocating resources for nodes to require the
autoSizingReserved: falseparameter. Also, I brought some of the text from Automatially allocating (with some slight changes) and the verification from Automatically allocating to this module (unchanged except for the example output).Link to docs preview:
QE review: