Skip to content

Conversation

@abrennan89 abrennan89 added this to the Planned for 4.21 GA milestone Jan 5, 2026
@abrennan89 abrennan89 added CNV Label for all CNV PRs branch/enterprise-4.21 labels Jan 5, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2026

@abrennan89: This pull request references CNV-70111 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
https://issues.redhat.com/browse/CNV-70111

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2026
@abrennan89 abrennan89 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2026

@abrennan89: This pull request references CNV-70111 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
https://issues.redhat.com/browse/CNV-70111

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Eng are currently making changes that may affect the implementation of this PR - placing on hold for now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@jcanocan jcanocan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to technical limitations, we have had to change the approach to this. In order to create license-compliant Windows VMs, instead of using a preference, users have to use an instancetype of the "d" (dedicated) family.

I have left suggestions to adjust the documentation to this new approach.

@abrennan89 abrennan89 force-pushed the CNV-70111 branch 2 times, most recently from d962de7 to 3b693c8 Compare January 13, 2026 16:47
@abrennan89 abrennan89 removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@abrennan89: This pull request references CNV-70111 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
https://issues.redhat.com/browse/CNV-70111

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@abrennan89 abrennan89 changed the title [WIP] CNV-70111: Add details about license-compliant windows VMs CNV-70111: Add details about license-compliant windows VMs Jan 13, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@abrennan89: This pull request references CNV-70111 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
https://issues.redhat.com/browse/CNV-70111

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dominikholler
Copy link

@BraeTroutman is the PR fine from your perspective, too?

@abrennan89 abrennan89 force-pushed the CNV-70111 branch 2 times, most recently from b78c62d to 6374c11 Compare January 14, 2026 15:17
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BraeTroutman
Copy link
Contributor

@dominikholler @abrennan89 this looks great! just one question: this feature is supported for OCP 4.19+, will these docs be backported all the way to that set of documentation?

@abrennan89
Copy link
Contributor Author

@BraeTroutman per https://issues.redhat.com/browse/CNV-70111 the fix version was 4.21, but if it applies for 4.19 I can absolutely backport it.

@abrennan89
Copy link
Contributor Author

We will follow up with picking this to z-stream versions later per Dominik's request. For now I'll merge this to 4.21 🙂


. Click *Add volume* to create a Windows boot source. You can create a Windows boot source by uploading a new volume or by using an existing persistent volume claim (PVC), a volume snapshot, or a `containerDisk` volume.

. In the *Volume metadata* section, select a preference with a name that begins with `windows` and followed with the Windows version of your choice. For example, `windows.11.virtio`. Click *Save*.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. In the *Volume metadata* section, select a preference with a name that begins with `windows` and followed with the Windows version of your choice. For example, `windows.11.virtio`. Click *Save*.
. In the *Volume metadata* section, select a preference with a name that begins with `windows` and is followed by the Windows version of your choice. For example, `windows.11.virtio`. Click *Save*.


. In the *User provided* tab, select an instance type with a name that begins with `d1`. For example, `d1.2xmedium` for a Windows 11 VM.

. Optional: You can mount a Windows driver disk by completing the following steps.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Optional: You can mount a Windows driver disk by completing the following steps.
. Optional: You can mount a Windows driver disk by completing the following steps:

@aspauldi
Copy link

Just a couple of things. Otherwise looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.21 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants