-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CNV-70111: Add details about license-compliant windows VMs #104373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@abrennan89: This pull request references CNV-70111 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@abrennan89: This pull request references CNV-70111 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jcanocan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to technical limitations, we have had to change the approach to this. In order to create license-compliant Windows VMs, instead of using a preference, users have to use an instancetype of the "d" (dedicated) family.
I have left suggestions to adjust the documentation to this new approach.
d962de7 to
3b693c8
Compare
|
@abrennan89: This pull request references CNV-70111 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@abrennan89: This pull request references CNV-70111 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@BraeTroutman is the PR fine from your perspective, too? |
b78c62d to
6374c11
Compare
|
@abrennan89: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dominikholler @abrennan89 this looks great! just one question: this feature is supported for OCP 4.19+, will these docs be backported all the way to that set of documentation? |
|
@BraeTroutman per https://issues.redhat.com/browse/CNV-70111 the fix version was 4.21, but if it applies for 4.19 I can absolutely backport it. |
|
We will follow up with picking this to z-stream versions later per Dominik's request. For now I'll merge this to 4.21 🙂 |
|
|
||
| . Click *Add volume* to create a Windows boot source. You can create a Windows boot source by uploading a new volume or by using an existing persistent volume claim (PVC), a volume snapshot, or a `containerDisk` volume. | ||
|
|
||
| . In the *Volume metadata* section, select a preference with a name that begins with `windows` and followed with the Windows version of your choice. For example, `windows.11.virtio`. Click *Save*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . In the *Volume metadata* section, select a preference with a name that begins with `windows` and followed with the Windows version of your choice. For example, `windows.11.virtio`. Click *Save*. | |
| . In the *Volume metadata* section, select a preference with a name that begins with `windows` and is followed by the Windows version of your choice. For example, `windows.11.virtio`. Click *Save*. |
|
|
||
| . In the *User provided* tab, select an instance type with a name that begins with `d1`. For example, `d1.2xmedium` for a Windows 11 VM. | ||
|
|
||
| . Optional: You can mount a Windows driver disk by completing the following steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Optional: You can mount a Windows driver disk by completing the following steps. | |
| . Optional: You can mount a Windows driver disk by completing the following steps: |
|
Just a couple of things. Otherwise looks great! |
Version(s):
4.21+
Issue:
https://issues.redhat.com/browse/CNV-70111
Link to docs preview:
QE review: