[CNV-74563] IBM Secure Execution GA upates #104527
Open
+109
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
|
🤖 Sat Jan 17 10:53:21 - Prow CI generated the docs preview: |
SNiemann15
changed the title
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
from
fce37e3 to
636d7bb
Compare
MirzWeiss
reviewed
Jan 12, 2026
modules/virt-launching-ibm-secure-execution-vm-using-common-instance-type-ibm-z.adoc
Outdated
Show resolved
Hide resolved
modules/virt-launching-ibm-secure-execution-vm-using-common-instance-type-ibm-z.adoc
Outdated
Show resolved
Hide resolved
MirzWeiss
reviewed
Jan 12, 2026
virt/creating_vm/virt-configuring-ibm-secure-execution-vms-ibm-z.adoc
Outdated
Show resolved
Hide resolved
modules/virt-launching-ibm-secure-execution-vm-using-cli-ibm-z.adoc
Outdated
Show resolved
Hide resolved
modules/virt-launching-ibm-secure-execution-vm-using-cli-ibm-z.adoc
Outdated
Show resolved
Hide resolved
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
2 times, most recently
from
d34b1e1 to
f2dadad
Compare
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
2 times, most recently
from
9f8aa63 to
bb36ee2
Compare
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
2 times, most recently
from
0bc7a5c to
05f3a14
Compare
sjhala-ccs
reviewed
Jan 15, 2026
virt/creating_vm/virt-configuring-ibm-secure-execution-vms-ibm-z.adoc
Outdated
Show resolved
Hide resolved
| // * virt/virtual_machines/creating_vm/virt-configuring-ibm-secure-execution-vms-ibm-z.adoc | ||
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| :_mod-docs-content-type: CONCEPT |
Contributor
There was a problem hiding this comment.
I am not sure if this needs to be a separate module. I would suggest deleting this module and replacing line 24 in the assembly file by:
[id="virt-launching-ibm-secure-execution-vm-ibm-z_{context}"]
== Launching an {ibm-title} Secure Execution VM on {ibm-z-title} and {ibm-linuxone-title}
Before launching an {ibm-name} Secure Execution VM on {ibm-z-name} and {ibm-linuxone-name}, you must add the `launchSecurity` parameter to the VM manifest. Otherwise, the VM does not start correctly because it does not have access to the devices.
Alternatively, you could just not have a == heading and directly include the information about the launchSecurity parameter in the procedure modules.
modules/virt-launching-ibm-secure-execution-vm-using-cli-ibm-z.adoc
Outdated
Show resolved
Hide resolved
modules/virt-launching-ibm-secure-execution-vm-using-cli-ibm-z.adoc
Outdated
Show resolved
Hide resolved
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
from
05f3a14 to
50878ef
Compare
virt/creating_vm/virt-configuring-ibm-secure-execution-vms-ibm-z.adoc
Outdated
Show resolved
Hide resolved
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
from
50878ef to
6f74188
Compare
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
from
480d412 to
edbe644
Compare
abrennan89
reviewed
Jan 16, 2026
Comment on lines
73
to
79
| .Prerequisites | ||
|
|
||
| * You have followed the procedure described in "Creating a VM from an instance type by using the web console" and performed the required steps. | ||
|
|
||
| * You are using an {ibm-name} Secure Execution enabled VM image. | ||
|
|
||
| .Procedure |
Contributor
There was a problem hiding this comment.
Only one procedure is allowed per module. This needs to be split into two modules.
Contributor
Author
There was a problem hiding this comment.
Ok I'll revert back.
SNiemann15
force-pushed
the
ocpvirt_ibmz_se_ga
branch
from
a42146b to
38c790a
Compare
|
@SNiemann15: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.21 +
Issue: https://issues.redhat.com/browse/CNV-74563
Link to docs preview: https://104527--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/creating_vm/virt-configuring-ibm-secure-execution-vms-ibm-z.html
QE review:
Additional information: