-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[OCPBUGS-29600]: Fixing 4.12 etcd restore procedure #104747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.12
Are you sure you want to change the base?
[OCPBUGS-29600]: Fixing 4.12 etcd restore procedure #104747
Conversation
00e7faf to
eaf5f2c
Compare
eaf5f2c to
1a9a4cd
Compare
| + | ||
| [NOTE] | ||
| ==== | ||
| It can take at least 5-10 minutes for the `OVN-Kubernetes` control plane to be redeployed and the previous command to return empty output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is duplicated, as it is written above and under the command. We need it only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| If the status is `Pending`, or the output lists more than one running `etcd` pod, wait a few minutes and check again. | ||
|
|
||
| . If you are using the `OVNKubernetes` network plugin, delete the node objects that are associated with control plane hosts that are not the recovery control plane host. | ||
| ... If you are using the `OVNKubernetes` network plugin, delete the node objects that are associated with control plane hosts that are not the recovery control plane host by using the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrongly nested. It should not be a child of the previous bullet point, but a new bullet point at the same level
| ... If you are using the `OVNKubernetes` network plugin, delete the node objects that are associated with control plane hosts that are not the recovery control plane host by using the following command: | |
| . If you are using the `OVNKubernetes` network plugin, delete the node objects that are associated with control plane hosts that are not the recovery control plane host by using the following command: |
Then the following points should be children of this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
1a9a4cd to
33cebf3
Compare
33cebf3 to
2b990f3
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.12
Issue: https://issues.redhat.com/browse/OCPBUGS-29600
Link to docs preview: https://104747--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state.html#dr-scenario-2-restoring-cluster-state_dr-restoring-cluster-state
QE review:
Additional information: This PR applies changes that Neal worked on with @palonsoro before Neal left Red Hat. See related PR, which Neal opened: #72302