Add integration tests for role assignments with same role on multiple scopes (Issue #513)#751
Open
MohidSheraz wants to merge 1 commit into
Conversation
gtema
requested changes
Jun 5, 2026
gtema
left a comment
gtema
left a comment
Collaborator
There was a problem hiding this comment.
Thanks.
apart of the other changes the commit message would need to be changed (use git commit --amend and specify a new message following the conventional commit summary (e.g., chore: Test role assignments with same role on multiple scopes)
| Ok(()) | ||
| } | ||
|
|
||
| // Add these two tests at the BOTTOM of: |
Collaborator
There was a problem hiding this comment.
this is likely the AI generated content and is making no sense here
| assert!( | ||
| target_ids.contains(&project_2.id), | ||
| "Assignment on project_2 should be present" | ||
| ); |
Collaborator
There was a problem hiding this comment.
please also add explicit validation that the role is granted on the system scope
| target_ids.contains(&project_2.id), | ||
| "Assignment on project_2 should be present when filtering by role_id" | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
also here should verify that a role is present on the system scope, not only the project
MohidSheraz
force-pushed
the
add-role-assignment-tests-issue-513
branch
4 times, most recently
from
679cf1a to
0b593a8
Compare
MohidSheraz
force-pushed
the
add-role-assignment-tests-issue-513
branch
from
0b593a8 to
a99ed34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #513
Added two integration tests to catch the bugs described in issue #513:
test_list_role_assignments_by_user_same_role_multiple_scopes
test_list_role_assignments_by_role_id_same_role_multiple_scopes
Both tests pass successfully.