feat: Add region CRUD to catalog SQL driver#761
Open
mashawes wants to merge 1 commit into
Open
Conversation
gtema
requested changes
Jun 5, 2026
Collaborator
gtema
left a comment
There was a problem hiding this comment.
mostly good, but few refinements are still necessary
Signed-off-by: Mohammed <mashawes@andrew.cmu.edu>
Collaborator
Author
|
Thanks for the review! Addressed all three points. Sorted struct fields and trait/impl methods alphabetically with blank lines between fields, and added validator length limits with max 255 characters taken from the Python region model. Ready for another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add region CRUD to catalog-driver-sql (#723)
Extends the catalog-sql driver with region CRUD, following the existing SQL-driver patterns.
Reads mirror the existing service/endpoint modules. Create/update/delete follow the patterns used in other SQL drivers.
Closes #723
Note: this contribution was developed with AI assistance