Update the mqeditor to use MathQuill's new internal toolbar.

[drgrice1]

These are changes needed to use the new internal toolbar implemented in openwebwork/mathquill#46. To test this you need to use that branch. Clone that branch somewhere on the webwork2 server, and then in the directory of that clone execute

npm ci
npm run build
npm link

Then checkout the branch for this pull request in the /opt/webwork/pg directory (or wherever you have the PG repository). Make sure you run npm ci in the pg/htdocs directory before doing the following so that the JavaScript and css for PG is all updated.

Then in the pg/htdocs directory run npm link @openwebwork/mathquill. After doing so if you look at pg/htdocs/node_modules/@openwebwork/mathquill you will see that it is now a link to the MathQuill clone above.

Now restart the webwork2 app.

One last important step. Since the package.json file is not changed (so the version of @openwebwork/mathquill is still reported as the same), the browser may still load the cached version of MathQuill. So you may need to do a hard refresh in the browser to get it to load the updated MathQuill javascript.

When you are done testing this branch, execute npm ci again to remove the symbolic link and go back to using the currently published MathQuill version.

Once openwebwork/mathquill#46 is merged, I will publish the changes in openwebwork/mathquill#46 and add it to this pull request. So don't merge this pull request until then.

Edit: Now that openwebwork/mathquill#46 has been merged and published, you can just test this by running npm ci as usual.

[Alex-Jordan]

I'm unsure that I am testing this correctly. I cloned the mathquill repo at /opt/webwork/mathquill and then I executed the commands above in that repo.

Then I checked out this branch of pg and in pg/htdocs I ran npm link @openwebwork/mathquill. I restarted webwork2. In a problem, I don't see changes with the toolbar. I understand they would largely be invisible to me. But for instance the "Disable Toolbar" whitespace issue from #1415 is still showing for me, so I think something I am doing is wrong.

[drgrice1]

I changed the testing instructions a bit. There were some steps I missed that might be why you weren't seeing the changes in effect.

[Alex-Jordan]

I am testing this again, and I followed the instructions.

Now when I click into an answer blank, I do not see the toolbar. Perhaps I had disabled it. But control-clicking does not give me the ususal Enable/Disable option. Instead I just get a generic input menu:

There are no console errors.

I'm using Firefox 151.0.1 on a Mac OS Tahoe 26.2.

[drgrice1]

Do you have any console errors or warnings?

[Alex-Jordan]

There are no console errors.

[drgrice1]

I am not sure what is going wrong for you. Can you delete the local storage key named MQEditorToolbarEnabled to see if the toolbar works (assuming you have that key)?

[drgrice1]

What is the minimized file generated for the mqeditor.js file? Is it js/MathQuill/mqeditor.fa95117d.min.js?

[drgrice1]

Can you verify that if you execute ls -l /opt/webwork/pg/htdocs/node_modules/@openwebwork it shows that mathquill is a symbolic link?

Try executing ./generate-assets.js from the pt/htdocs directory and restart the webwork2 app. Executing the generate-assets.js script will make sure that you have the correct minified javascript and css files for the pull request, but won't change the symbolic link back to the actual upstream @openwebwork/mathquill package contents (npm ci will do that).

[Alex-Jordan]

Can you delete the local storage key named MQEditorToolbarEnabled to see if the toolbar works (assuming you have that key)?

In local storage, I saw that variable, and it is set to true. So I didn't think this would help.

But I deleted it anyway, and reloaded the page. Now everything is working. And I also see the excess whitespace from "Disable Toolbar" is gone, so I know I'm on the right branch.

So....good? Is there anything I should do to test the other changes? Would Apple VoiceOver reveal changes now?

[drgrice1]

I have not tested with Apple VoiceOver. Testing with that would be good. There should be differences between this pull request and the PG-2.21 branch. Particularly when you use toolbar buttons.

[Alex-Jordan]

Alright, I gave it a go. But using Apple VoiceOver is torture. Either it's broken on my Mac, or navigation with that on just makes no sense. I tried using Apple's tutorial too, and it doesn't help. I think I would need to use it in person with a human training me.

So I have nothing to add. But nothing seems broken! So I will approve the PR.

[drgrice1]

I remember testing it on my daughter's school MacBook at some point. I didn't know how to use it either. I also tested the Android TalkBack, and had much the same experience. I have figured out how to use Gnome Orca and NCDA, but that also took some time to figure out. Screen reader usage does seem to not be easy.

[somiaj]

@drgrice1 npm link wants write access to to /usr/local/lib/node_modules. I thought there was a way to link this without going through that extra step so I can link to mathquill repo more directly? Or is there a way to specify where to put the node modules in $HOME?

[drgrice1]

Yeah, I set npm to use a local location (~/.local/lib/node_modules). I didn't think about that. Add prefix=~/.local to the .npmrc file to get this.

[somiaj]

In testing this, the enable/disable toolbar seems to be for individual mathquilll blanks when initially changing the setting.

I have a problem, multiple answer blanks, toolbar is enabled. I click disable toolbar, I go to the next blank, it is still enabled. In effect I can enable/disable per answer box of a currently open problem.

Now if I reload the page, the default is set to whatever the last setting was for enabled/disabled. So the initial load they are all in the same state.

[drgrice1]

Hmm... I am seeing that too. I will look into it.

[drgrice1]

That issue is fixed in openwebwork/mathquill#47.

[drgrice1]

I went ahead and published @openwebwork/mathquill#47 to npm and added it to this branch (although that pull request is not merged into @openwebwork/mathquill yet). So you can test this pull request directly by just running npm ci.

[somiaj]

Everything I tested work now that the enable/disable is fixed.

[somiaj]

I'll leave it to someone else to double check things via npm ci before merging.

[Alex-Jordan]

I checked again with a fresh npm ci and it is all working, including with the newer Enable/Disable issue.