Selet AI Tests for Vector Index. by Pushpendra-Garg · Pull Request #32 · oracle/python-select-ai

Pushpendra-Garg · 2026-05-05T07:33:13Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

oracle-contributor-agreement · 2026-05-05T07:33:19Z

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

pushgarg@phoenix311728.dev3sub3phx.databasede3phx.oraclevcn.com

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

aosingh · 2026-05-05T19:13:24Z

+@pytest.fixture(scope="session")
+def credential_connect_as(test_env):
+    def _connect_as(admin=False, **overrides):
+        select_ai.disconnect()


Please don't run select_ai.disconnect() in individual conftest.

We have seen this causes issues as it modifies the global connection state. We already have connect/disconnect in the root level conftest.py which is automatically run for every module.

https://github.com/oracle/python-select-ai/blob/main/tests/conftest.py#L201

We should not do any connection management in individual test suites.

Removed additional connect/disconnect from subfolders.

aosingh · 2026-05-05T19:15:59Z

+@pytest.fixture(scope="session")
+def credential_async_connect_as(test_env):
+    async def _connect_as(admin=False, **overrides):
+        await select_ai.async_disconnect()


We already have async connect and disconnect here
https://github.com/oracle/python-select-ai/blob/main/tests/conftest.py#L208

No need to connect here

Removed additional connect/disconnect from subfolders.

aosingh · 2026-06-06T00:10:04Z

@Pushpendra-Garg please rebase changes from main. Thanks

This reverts commit 0025e80.

This reverts commit 54c28bd.

Pushpendra-Garg · 2026-06-10T12:29:43Z

@Pushpendra-Garg please rebase changes from main. Thanks

Done.

aosingh · 2026-06-10T16:46:15Z

          pip install pytest anyio
          pip install -e .

+      - name: Debug vector index secret wiring


Can we please remove this debug step ?

aosingh · 2026-06-10T16:46:59Z

@@ -0,0 +1,51 @@
+# -----------------------------------------------------------------------------
+# Copyright (c) 2025, Oracle and/or its affiliates.


For new files, Copyright header should use the current year - 2026

aosingh · 2026-06-10T16:47:19Z

@@ -0,0 +1,415 @@
+# -----------------------------------------------------------------------------
+# Copyright (c) 2025, Oracle and/or its affiliates.


aosingh · 2026-06-10T16:48:00Z

@@ -0,0 +1,356 @@
+# -----------------------------------------------------------------------------
+# Copyright (c) 2025, Oracle and/or its affiliates.


Please update the year in all files

aosingh · 2026-06-10T17:00:07Z

+        logger.info(f"SetUp for {method.__name__}")
+        self.objstore_cred = "OBJSTORE_CRED"
+        self.vecidx = select_ai.VectorIndex()
+        self.vector_index = list(self.vecidx.list(index_name_pattern=".*"))[0]


This will operate on whichever vector index happens to be returned first, not the index created in setup. In a shared schema or after earlier tests, this can validate/disable the wrong object. Fetch by exact name, for example index_name_pattern=f"^{self.index_name}$", and assert exactly one match.

aosingh · 2026-06-10T17:08:03Z

+
+    def test_2217(self):
+        """Test Credential creation for a local test user"""
+        test_username = "TEST_USER1"


We run tests for different Python versions in parallel. Creating TEST_USER1 is unsafe for parallel runs. Use UUID/suffix-based names derived from the test session, and always drop them in finally.

aosingh · 2026-06-10T17:12:57Z

+
+    try:
+        for i in range(1, 6):
+            user = f"DB_USER{i}"


Don't use user names like DB_USER1, DB_USER2. In a shared CI infrastructure this can break parallel runs. Use UUID/suffix-based names derived from the test session, and always drop them in finally

aosingh · 2026-06-10T17:15:08Z

+        """Test None as pattern input."""
+        logger.info("Testing None as pattern input...")
+        indexes = self.vector_index.list(None)
+        assert len(list(indexes)) != len(self.indexes)


What are we testing here ?

aosingh · 2026-06-10T17:15:40Z

+        """Test empty string as pattern input."""
+        logger.info("Testing empty string as pattern input...")
+        indexes = self.vector_index.list("")
+        assert len(list(indexes)) != len(self.indexes)


Same, what is tested here ?

oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 5, 2026

Pushpendra-Garg self-assigned this May 5, 2026

Pushpendra-Garg requested review from aosingh, deepak-oracle and prateeks99 May 5, 2026 07:34

Pushpendra-Garg force-pushed the vecindex_sync branch 3 times, most recently from 730fdcd to 4936204 Compare May 5, 2026 08:19

aosingh reviewed May 5, 2026

View reviewed changes

pushpendra.garg@oracle.com added 9 commits June 8, 2026 15:52

Selet AI Tests for Vector Index.

b039f5a

Align test conftests with review feedback

74c545b

Add object store envs to test workflow

f396202

Grant vector-index Object Storage host access in tests

4bd24bc

Add temporary Actions debug for vector index secrets

74cc27e

Quote object store password secret in test workflow

86bff35

Quote object store password in test run env

7b76a13

Revert "Quote object store password in test run env"

950df80

This reverts commit 0025e80.

Revert "Quote object store password secret in test workflow"

c06f8d4

This reverts commit 54c28bd.

Pushpendra-Garg force-pushed the vecindex_sync branch from a480731 to c06f8d4 Compare June 8, 2026 15:55

Restore conftest.py to main behavior

813394d

prateeks99 approved these changes Jun 10, 2026

View reviewed changes

aosingh reviewed Jun 10, 2026

View reviewed changes

		@@ -0,0 +1,51 @@
		# -----------------------------------------------------------------------------
		# Copyright (c) 2025, Oracle and/or its affiliates.

		@@ -0,0 +1,415 @@
		# -----------------------------------------------------------------------------
		# Copyright (c) 2025, Oracle and/or its affiliates.

		@@ -0,0 +1,356 @@
		# -----------------------------------------------------------------------------
		# Copyright (c) 2025, Oracle and/or its affiliates.

Conversation

Pushpendra-Garg commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

oracle-contributor-agreement Bot commented May 5, 2026

Uh oh!

aosingh May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aosingh commented Jun 6, 2026

Uh oh!

Pushpendra-Garg commented Jun 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aosingh Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pushpendra-Garg commented May 5, 2026 •

edited

Loading

aosingh May 5, 2026 •

edited

Loading

aosingh Jun 10, 2026 •

edited

Loading