[FEATURE REQUEST] Allow passcode and pattern screens in landscape mode#4871
Open
joragua wants to merge 5 commits into
Open
[FEATURE REQUEST] Allow passcode and pattern screens in landscape mode#4871joragua wants to merge 5 commits into
joragua wants to merge 5 commits into
Conversation
joragua
force-pushed
the
feature/passcode_and_pattern_in_landscape
branch
3 times, most recently
from
1d70daa to
6c990bc
Compare
joragua
force-pushed
the
feature/passcode_and_pattern_in_landscape
branch
from
6c990bc to
0cb53a7
Compare
jesmrec
requested changes
May 22, 2026
joragua
force-pushed
the
feature/passcode_and_pattern_in_landscape
branch
from
458e066 to
1464890
Compare
jesmrec
approved these changes
May 25, 2026
Contributor
jesmrec
left a comment
jesmrec
left a comment
There was a problem hiding this comment.
CR approved!! moving to QA
Contributor
(1)
Current: Typed characters are correctly stored, but point indicators are missing on UI
Expected: UI status keeps after orientation changes Xiaomi Redmi Note 2, Android 15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App: -
Starting from Android 16, Android will ignore resizability and orientation restrictions for large screen devices, such as foldables and tablets. That means that the
android: screenOrientationconfiguration in the manifest will be ignored, and screens using that configuration should support both orientations (portrait and landscape). In our case, we have two screens affected by this restriction: passcode and pattern screensWork done:
Passcode
w600dpwithsw600dpin order to use the layout-land for phones in landscapePattern
w600dpwithsw600dpin order to use the layout-land for phones in landscapeReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA
Test plan:
Reports: