refactor: Upgrade ws to 7.5.10 (GHSA-3h5v-q93c-6h6q)#10363
refactor: Upgrade ws to 7.5.10 (GHSA-3h5v-q93c-6h6q)#10363mtrezza merged 1 commit intoparse-community:alphafrom
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. |
📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10363 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 192 192
Lines 16566 16566
Branches 231 231
=======================================
Hits 15327 15327
Misses 1217 1217
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Security Fix
Advisory: GHSA-3h5v-q93c-6h6q
Severity: high (CVSS 7.5)
Vulnerability: DoS via excessive HTTP headers (CWE-476)
Package:
ws7.5.9 → 7.5.10Dependency path:
@apollo/client > subscriptions-transport-ws > wsExposure in This Project
Indirectly exposed — The vulnerable
ws@7.5.9is pulled in bysubscriptions-transport-ws(a transitive dep of@apollo/client). The project's directwsdependency is already at 8.20.0 (not vulnerable). The vulnerable code path requires sending 2000+ headers in a WebSocket upgrade request to the GraphQL subscriptions endpoint.Changes
wsfrom 7.5.9 to 7.5.10 withinsubscriptions-transport-wsdependency tree (lock file only)Code Changes Required
None — the upgrade is a drop-in replacement (lock file change only).
Verification
npm auditno longer reports this advisorynpm run buildpassesSummary by CodeRabbit