Skip to content

refactor: Upgrade ws to 7.5.10 (GHSA-3h5v-q93c-6h6q)#10363

Merged
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:fix/ws-GHSA-3h5v-q93c-6h6q
Mar 31, 2026
Merged

refactor: Upgrade ws to 7.5.10 (GHSA-3h5v-q93c-6h6q)#10363
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:fix/ws-GHSA-3h5v-q93c-6h6q

Conversation

@mtrezza
Copy link
Copy Markdown
Member

@mtrezza mtrezza commented Mar 31, 2026

Security Fix

Advisory: GHSA-3h5v-q93c-6h6q
Severity: high (CVSS 7.5)
Vulnerability: DoS via excessive HTTP headers (CWE-476)
Package: ws 7.5.9 → 7.5.10
Dependency path: @apollo/client > subscriptions-transport-ws > ws

Exposure in This Project

Indirectly exposed — The vulnerable ws@7.5.9 is pulled in by subscriptions-transport-ws (a transitive dep of @apollo/client). The project's direct ws dependency is already at 8.20.0 (not vulnerable). The vulnerable code path requires sending 2000+ headers in a WebSocket upgrade request to the GraphQL subscriptions endpoint.

Changes

  • Updated ws from 7.5.9 to 7.5.10 within subscriptions-transport-ws dependency tree (lock file only)
  • Version 7.5.10 backports a fix that prevents server crash when handling requests with many HTTP headers

Code Changes Required

None — the upgrade is a drop-in replacement (lock file change only).

Verification

  • npm audit no longer reports this advisory
  • npm run build passes

Summary by CodeRabbit

  • Chores
    • Updated WebSocket library dependency to the latest patch version for improved stability.

@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant bot commented Mar 31, 2026

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

Updated the ws WebSocket dependency in package-lock.json from version 7.5.9 to 7.5.10, including changes to the resolved tarball URL, integrity hash, and addition of a license field for nested dependency instances.

Changes

Cohort / File(s) Summary
Dependency Update
package-lock.json
Updated ws package from 7.5.9 to 7.5.10 with new resolved URL and integrity hash; added license: "MIT" field to the nested subscriptions-transport-ws/node_modules/ws entry and the top-level ws entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides comprehensive context about the security fix, but does not follow the required template structure with Issue, Approach, and Tasks sections. Restructure the description to match the template format: add an Issue section, Approach section, and complete the Tasks checklist with appropriate items.
Human Review ❓ Inconclusive Custom check requires verification that a human reviewed PR #10363, but this information is not accessible through repository codebase alone. Access GitHub PR #10363's Reviews tab to confirm human reviewer approval, or configure branch protection rules requiring human review approval before merging.
Engage In Review Feedback ❓ Inconclusive Cannot access GitHub PR review comments and discussion history required to verify user engagement with review feedback on PR #10363. Provide GitHub PR #10363 comments/discussion access or authenticate with GitHub API to retrieve PR review data and assess engagement.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed Pull request successfully upgrades ws package from 7.5.9 to 7.5.10, fixing GHSA-3h5v-q93c-6h6q DoS vulnerability without introducing new issues.
Title check ✅ Passed The PR title begins with 'refactor:' prefix, which is an approved prefix per requirements. However, the PR addresses a security vulnerability (GHSA-3h5v-q93c-6h6q), making 'fix:' the more semantically accurate prefix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (a0b0c69) to head (6e4b85c).
⚠️ Report is 2 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha   #10363   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files         192      192           
  Lines       16566    16566           
  Branches      231      231           
=======================================
  Hits        15327    15327           
  Misses       1217     1217           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza changed the title fix: Upgrade ws to 7.5.10 (GHSA-3h5v-q93c-6h6q) refactor: Upgrade ws to 7.5.10 (GHSA-3h5v-q93c-6h6q) Mar 31, 2026
@mtrezza mtrezza merged commit 8a581e9 into parse-community:alpha Mar 31, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant