fix(icons): update internal import specifier#12265
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughChanged import/export strings to include explicit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12265.surge.sh A11y report: https://pf-react-pr-12265-a11y.surge.sh |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #
Changes in our react/icons now fully specifies our dist/esm output as an ESM module, which requires all imports to be specified. So
import { createIcon } from '../createIconis not valid (and likely hasn't been, but this specifier rule either wasn't enforced by older versions of Node/webpack/etc, or the package wasn't fully being treated as ESM since we hadn't previously specifiedtype: module).Summary by CodeRabbit