Fix inconsistent bounds description in stats_rand_gen_funiform() #5105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jan 14, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
The PECL source code seems to say that exclusive is correct: https://github.com/php/pecl-math-stats/blob/master/randlib.c#L702
Contributor
Author
|
Thanks for the clarification and for pointing to the implementation @Girgias |
Girgias
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function description stated that both bounds were exclusive, while the parameter documentation specifies that the lower bound is inclusive and the upper bound exclusive.
This change aligns the refpurpose with the documented parameter behavior and removes an internal inconsistency.
Issue: #4984