Conversation
|
Looks like race condition in PHP 8.2, unrelated to any recent changes. Not sure if people are actually experiencing this or if it just happens in tests. |
|
What's the point in moving the tests to caddy? |
|
Moving to caddy was just an experiment, will probably move them back. |
|
This branch now just deactivates the |
|
I would hope not many people use FrankenPHP with PHP < 8.4 anyway. 8.2 also still had real differences in performance between NTS and ZTS. So I think it's acceptable to skip the test on 8.2, though as it seems unrelated to frankenphp itself it should maybe be raised with php. Edit: actually probably not, given that it's not a security issue, just a crash. |
| // setup custom environment var for TestWorkerHasOSEnvironmentVariableInSERVER | ||
| if os.Setenv("CUSTOM_OS_ENV_VARIABLE", "custom_env_variable_value") != nil { | ||
| // setup custom environment var for TestWorkerHasOSEnvironmentVariableInSERVER and TestPhpIni | ||
| if os.Setenv("CUSTOM_OS_ENV_VARIABLE", "custom_env_variable_value") != nil || os.Setenv("LITERAL_ONE", "1") != nil { |
There was a problem hiding this comment.
make this a LITERAL_ZERO instead, opcache is enabled by default so we should explicitly disable it here
2 participants
Fixes the Docker image tests currently failing in CI.