Skip to content

fix(release): stage PGO blob through --rawfile to avoid ARG_MAX #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 2 commits into from
May 15, 2026
+11 −3
Merged

fix(release): stage PGO blob through --rawfile to avoid ARG_MAX #2421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7895465
fix(release): stage PGO blob through --rawfile to avoid ARG_MAX
dunglas May 15, 2026
4075145
fix(release): clean up base64 tmpfile even on jq/gh failure
dunglas May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,19 @@ jobs:
commit_sha="${RELEASE_COMMIT}"
echo "Reusing existing release commit ${commit_sha}"
else
make_blob() {
jq -nc --arg content "$(base64 -w0 <"$1")" \
# Stage the base64 in a temp file and feed it to jq via
# --rawfile: passing big blobs (the PGO profile is ~2 MB encoded)
# through --arg exceeds ARG_MAX on the runner. Subshell body +
# EXIT trap clean up the tmpfile even if base64/jq/gh aborts.
make_blob() (
local tmp
tmp=$(mktemp)
trap 'rm -f "$tmp"' EXIT
base64 -w0 <"$1" >"$tmp"
jq -nc --rawfile content "$tmp" \
'{content: $content, encoding: "base64"}' \
| gh api "repos/${REPO}/git/blobs" --input - -q .sha
}
)

parent_sha=$(gh api "repos/${REPO}/git/refs/heads/main" -q .object.sha)
base_tree=$(gh api "repos/${REPO}/git/commits/${parent_sha}" -q .tree.sha)
Expand Down
Loading