Open
Conversation
Member
|
Would probably make sense to split this into more self-contained commits. e.g. the |
Girgias
force-pushed
the
constify-attribute-ce
branch
from
a1beac3 to
4087034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See motivation in: #19045 (comment)
One problem is that during the chain we reach
zend_ast_evaluate()which passes the scope tozend_ast_evaluate_inner(), which passes the scope tozend_create_closure(), this then assigns this to thecalled_scopefield ofzend_closure.However, this field is accessible via the
**ce_ptrargument ofzend_closure_get_closure(), and this then creates a whole new chain of being used in FCCs that I haven't been able to track yet.