ext/opcache: minor refactoring (2026-03)#21397
Open
Girgias wants to merge 6 commits intophp:masterfrom
Open
Conversation
TimWolla
reviewed
Mar 9, 2026
arnaud-lb
reviewed
Mar 10, 2026
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
Looks good to me apart from Tim's comment
iluuu1994
reviewed
Mar 10, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Looks ok to me, apart from the comment made by Tim.
ext/opcache/ZendAccelerator.c
Outdated
| for (i = 0; i < entry->dependencies_count; i++) { | ||
| zend_class_entry *ce = zend_lookup_class_ex(entry->dependencies[i].name, NULL, 0); | ||
| for (uint32_t i = 0; i < entry->dependencies_count; i++) { | ||
| const zend_class_entry *dependent_ce = zend_lookup_class_ex(entry->dependencies[i].name, NULL, 0); |
Member
There was a problem hiding this comment.
Nit: Technically the name dependent_ce indicates a dependency of dependent_ce on ce, rather than the other way around.
Member
Author
There was a problem hiding this comment.
Do you have an idea for a better name? dependency_of_ce maybe?
dstogov
reviewed
Mar 18, 2026
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
I don't care about this.
If @iluuu1994 approves this, I don't object.
Girgias
force-pushed
the
opcache-minor-refactoring-2026-03
branch
from
ae63da1 to
964b903
Compare
iluuu1994
reviewed
Mar 21, 2026
| { | ||
| zend_file_handle ps_handle; | ||
| zend_string *full_path_ptr = NULL; | ||
| int ret; |
Member
There was a problem hiding this comment.
Should be?
Suggested change
| zend_result ret; |
| if (found && entry->dependencies) { | ||
| for (i = 0; i < entry->dependencies_count; i++) { | ||
| zend_class_entry *ce = zend_lookup_class_ex(entry->dependencies[i].name, NULL, ZEND_FETCH_CLASS_NO_AUTOLOAD); | ||
| const zend_class_entry *dependent_ce = zend_lookup_class_ex(entry->dependencies[i].name, NULL, ZEND_FETCH_CLASS_NO_AUTOLOAD); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed in order.