Skip to content

fix: add escaped closing docblock to escaped sequences #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bshaffer wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

fix: add escaped closing docblock to escaped sequences #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/DocBlock/DescriptionFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,9 @@ private function lex(string $contents): array

return Utils::pregSplit(
'/\{
# "{@}" is not a valid inline tag. This ensures that we do not treat it as one, but treat it literally.
(?!@\})
# "{@}" and "{@*}" are not a valid inline tags. This ensures that we do not treat them as one, but treat
# them literally.
(?!(?:@\}|@\*\}) )
# We want to capture the whole tag line, but without the inline tag delimiters.
(\@
# Match everything up to the next delimiter.
Expand Down
1 change: 1 addition & 0 deletions tests/unit/DocBlock/DescriptionFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ public function provideEscapeSequences(): array
{
return [
['This is text for a description with a {@}.', 'This is text for a description with a @.'],
['This is text for a description with a {@*}.', 'This is text for a description with a {@*}.'],
['This is text for a description with a {}.', 'This is text for a description with a }.'],
];
}
Expand Down