Switch HasMethodType/HasPropertyType from ObjectTypeTrait to MaybeObjectTypeTrait#5605

Open

phpstan-bot wants to merge 15 commits intophpstan:2.1.xfrom

phpstan-bot:create-pull-request/patch-7ulxx4w

Commits on May 10, 2026

Do not let `method_exists()` check fall through to general logic when object type contains template types
VincentLanglet
committed
Add test cases for method_exists with mixed and object types

authored and
VincentLanglet
committed
Fix at type system level: override hasMethod() on TemplateMixedType to return Maybe

authored and
VincentLanglet
committed
Move fix from TemplateMixedType::hasMethod() to ImpossibleCheckTypeHelper

authored and
VincentLanglet
committed
Fix HasMethodType::isSuperTypeOf() to delegate to isSubTypeOf() for CompoundTypes

authored and
VincentLanglet
committed
Fix HasPropertyType::isSuperTypeOf() to delegate to isSubTypeOf() for CompoundTypes

authored and
VincentLanglet
committed
Simplify HasMethodType/HasPropertyType::isSuperTypeOf() CompoundType delegation

authored and
VincentLanglet
committed
Fall back to hasMethod()/hasProperty() when CompoundType::isSubTypeOf() returns No

authored and
VincentLanglet
committed
Override string/scalar type queries on HasMethodType/HasPropertyType to return Maybe

authored and
VincentLanglet
committed
Simplify HasMethodType/HasPropertyType::isSuperTypeOf() CompoundType delegation

authored and
VincentLanglet
committed
Extract MaybeStringTypeTrait from HasOffsetType/HasOffsetValueType

authored and
VincentLanglet
committed
Switch HasMethodType/HasPropertyType from ObjectTypeTrait to MaybeObjectTypeTrait

authored and
VincentLanglet
committed
Address review: deduplicate via MaybeStringTypeTrait, remove redundant overrides, fix getClassStringObjectType

authored and
VincentLanglet
committed
Fix
VincentLanglet
committed
Remove unused ClassMemberAccessAnswerer import from HasPropertyType

phpstan-bot
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch HasMethodType/HasPropertyType from ObjectTypeTrait to MaybeObjectTypeTrait#5605

Switch HasMethodType/HasPropertyType from ObjectTypeTrait to MaybeObjectTypeTrait#5605
phpstan-bot wants to merge 15 commits intophpstan:2.1.xfrom
phpstan-bot:create-pull-request/patch-7ulxx4w

Commits on May 10, 2026

Do not let `method_exists()` check fall through to general logic when object type contains template types

Add test cases for method_exists with mixed and object types

Fix at type system level: override hasMethod() on TemplateMixedType to return Maybe

Move fix from TemplateMixedType::hasMethod() to ImpossibleCheckTypeHelper

Fix HasMethodType::isSuperTypeOf() to delegate to isSubTypeOf() for CompoundTypes

Fix HasPropertyType::isSuperTypeOf() to delegate to isSubTypeOf() for CompoundTypes

Simplify HasMethodType/HasPropertyType::isSuperTypeOf() CompoundType delegation

Fall back to hasMethod()/hasProperty() when CompoundType::isSubTypeOf() returns No

Override string/scalar type queries on HasMethodType/HasPropertyType to return Maybe

Simplify HasMethodType/HasPropertyType::isSuperTypeOf() CompoundType delegation

Extract MaybeStringTypeTrait from HasOffsetType/HasOffsetValueType

Switch HasMethodType/HasPropertyType from ObjectTypeTrait to MaybeObjectTypeTrait

Address review: deduplicate via MaybeStringTypeTrait, remove redundant overrides, fix getClassStringObjectType

Fix

Remove unused ClassMemberAccessAnswerer import from HasPropertyType