replace on-finished with stream.finished

[bjohansebas]

on-finished can be replaced by finished, isFinished is still required for future maintainability

[Copilot]

Pull Request Overview

This pull request replaces the usage of on-finished with the built-in stream.finished for flushing the request, while still maintaining the isFinished check via on-finished for future maintainability.

• Replaces onFinished(req, write) with finished(req, write)
• Removes redundant module variables and adjusts variable declarations accordingly

Comments suppressed due to low confidence (1)

index.js:18

• [nitpick] Consider using 'const' instead of 'var' for 'isFinished' to promote immutability and maintain consistency with other modern declarations.

var isFinished = require('on-finished').isFinished

[Phillip9587]

I really like the direction of this change - using stream.finished is definitely a cleaner and more modern approach. However, I'd be in favor of implementing this improvement directly within the on-finished package and releasing it as a new major version.

This way, we can centralize the logic, maintain consistency for our packages that depend on on-finished, and allow consumers to benefit from the native stream.finished without having to refactor their own usage across different codebases.

Curious to hear your thoughts on this approach!

[bjohansebas]

Closing since version 3 of on-finished is being worked on.