Skip to content

v8.5.6: Add new session variable "tidb_opt_partial_ordered_index_for_topn" (#22495)#22737

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:feature/preview-v8.5.6from
ti-chi-bot:cherry-pick-22495-to-release-8.5
Apr 13, 2026
Merged

v8.5.6: Add new session variable "tidb_opt_partial_ordered_index_for_topn" (#22495)#22737
ti-chi-bot[bot] merged 7 commits intopingcap:feature/preview-v8.5.6from
ti-chi-bot:cherry-pick-22495-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #22495

First-time contributors' checklist

What is changed, added or deleted? (Required)

Explain the new session variable "tidb_opt_partial_ordered_index_for_topn" in sys-var doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Related issue: pingcap/tidb#65813

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

qiancai and others added 6 commits April 13, 2026 02:54
Synced from: pingcap/docs-cn#21318
Target PR: pingcap#22495
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 13, 2026
@ti-chi-bot ti-chi-bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for the new system variable tidb_opt_partial_ordered_index_for_topn, available in v8.5.6 and v9.0.0. The variable allows the optimizer to leverage partial index ordering to optimize TopN computations. The review feedback focuses on aligning the documentation with the style guide by using active voice, addressing the user in the second person, and removing redundant phrasing to improve clarity and conciseness.

Comment thread system-variables.md
Comment thread system-variables.md
Comment thread system-variables.md
Comment thread system-variables.md
Comment thread system-variables.md
Comment thread system-variables.md Outdated
@qiancai qiancai changed the title Add new session variable "tidb_opt_partial_ordered_index_for_topn" (#22495) v8.5.6: Add new session variable "tidb_opt_partial_ordered_index_for_topn" (#22495) Apr 13, 2026
@qiancai qiancai changed the base branch from release-8.5 to feature/preview-v8.5.6 April 13, 2026 05:57
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Apr 13, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit 23fa2ad into pingcap:feature/preview-v8.5.6 Apr 13, 2026
12 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-22495-to-release-8.5 branch April 13, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants