-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Clean up pyproject.toml and build pipeline
#5540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
1c6204e
77aeae4
ef2359e
0cfdc0d
09d817a
18c6b75
3adab20
a650b15
4e06ef0
796a9b3
0352c8a
6a70d14
ed73ee3
7c5c884
1a13239
a98060d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,4 @@ | ||
| { | ||
| "schemaVersion": 1, | ||
| "packageName": "jupyterlab-plotly", | ||
| "version": "6.0.1", | ||
| "packageManager": "python", | ||
| "jupyterlab": { | ||
| "mimeExtension": "lib/mimeExtension.js" | ||
| } | ||
| "packageName": "plotly", | ||
| "packageManager": "python" | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| module.exports = { | ||
| // Note: This config has no effect on the lab extension functionality, | ||
| // but it helps ensure that webpack uses the same module and chunk IDs | ||
| // across platforms, which makes it easier to compare build artifacts. | ||
| optimization: { | ||
| moduleIds: 'natural', | ||
| chunkIds: 'natural', | ||
| realContentHash: true | ||
| }, | ||
| }; |
Large diffs are not rendered by default.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=71"] | ||
| build-backend = "setuptools.build_meta" | ||
| requires = ["hatchling >= 1.26"] | ||
| build-backend = "hatchling.build" | ||
|
|
||
| [project.urls] | ||
| "HomePage" = "https://plotly.com/python/" | ||
| "Homepage" = "https://plotly.com/python/" | ||
| "Documentation" = "https://plotly.com/python/" | ||
| "Github" = "https://github.com/plotly/plotly.py" | ||
| "GitHub" = "https://github.com/plotly/plotly.py" | ||
| "Changelog" = "https://github.com/plotly/plotly.py/blob/main/CHANGELOG.md" | ||
|
|
||
| [project] | ||
|
|
@@ -18,7 +18,7 @@ maintainers = [ | |
| { name="Emily Kellison-Linn", email="emily@plot.ly" } | ||
| ] | ||
| description = "An open-source interactive data visualization library for Python" | ||
|
|
||
| readme = {file = "README.md", content-type = "text/markdown"} | ||
| readme = "README.md" | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "Programming Language :: Python :: 3.8", | ||
|
|
@@ -31,7 +31,8 @@ classifiers = [ | |
| "License :: OSI Approved :: MIT License" | ||
| ] | ||
| requires-python = ">=3.8" | ||
| license = {file="LICENSE.txt"} | ||
| license = "MIT" | ||
emilykl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| license-files = ["LICENSE.txt"] | ||
| version = "6.6.0" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does uv have something similar to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hatch itself has a whole system for build hooks which we could definitely make use of. I started going down that path for compiling the JS artifacts (i.e., adding the |
||
| dependencies = [ | ||
| "narwhals>=1.15.1", | ||
|
|
@@ -50,7 +51,7 @@ dev_core = [ | |
| dev_build = [ | ||
| "plotly[dev_core]", | ||
| "build", | ||
| "jupyter" | ||
| "jupyterlab" | ||
| ] | ||
| dev_optional = [ | ||
| "plotly[dev_build]", | ||
|
|
@@ -91,43 +92,17 @@ markers = [ | |
| "matplotlib: mark a test as matplotlib" | ||
| ] | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| where = ["."] | ||
| include = ["plotly*", "_plotly*"] | ||
| exclude = ["__pycache__*", "tests*"] | ||
|
|
||
| [tool.setuptools.package-data] | ||
| plotly = [ | ||
| "package_data/*", | ||
| "package_data/templates/*", | ||
| "package_data/datasets/*", | ||
| "validators/_validators.json" | ||
| ] | ||
|
|
||
| [tool.jupyter-packaging.builder] | ||
| factory = "jupyter_packaging.npm_builder" | ||
| auto_data_files = true | ||
|
|
||
| [tool.jupyter-packaging.build-args] | ||
| build_cmd = "build:prod" | ||
| npm = ["jlpm"] | ||
|
|
||
| [tool.hatch.build.hooks.jupyter-builder] | ||
| editable-frontend = true | ||
|
|
||
| [tool.hatch.build.hooks.jupyter-builder.editable-build-kwargs] | ||
| build_cmd = "build" | ||
| npm = ["jlpm"] | ||
| source_dir = "js" | ||
| build_dir = "plotly/labextension" | ||
| skip_symlink = true | ||
|
|
||
| [tool.setuptools.data-files] | ||
| "share/jupyter/labextensions/jupyterlab-plotly" = [ | ||
| "plotly/labextension/package.json", | ||
| "js/install.json" | ||
| [tool.hatch.build] | ||
| include = [ | ||
| "/plotly*", | ||
| "/_plotly*", | ||
| "js/install.json", # used by Jupyter extension | ||
| ] | ||
|
|
||
| "share/jupyter/labextensions/jupyterlab-plotly/static" = [ | ||
| "plotly/labextension/static/*.js" | ||
| ] | ||
| [tool.hatch.build.targets.wheel.shared-data] | ||
| # Specify files from this package which will be copied to the user's system on install | ||
| # This is how the jupyterlab extension gets installed | ||
| # Left path is the path within this package | ||
| # Right path is the path on the user's system | ||
| "plotly/labextension" = "share/jupyter/labextensions/jupyterlab-plotly" | ||
| "js/install.json" = "share/jupyter/labextensions/jupyterlab-plotly/install.json" | ||
Uh oh!
There was an error while loading. Please reload this page.