Fixed ui of the collection table#3918
Open
SinhaS12 wants to merge 6 commits intoprocessing:developfrom
Open
Conversation
Contributor
Author
|
Hi @raclim 👋 |
clairep94
reviewed
Mar 7, 2026
| }, | ||
| "Sidebar": { | ||
| "Title": "Sketch Files", | ||
| "Title": "Sketch something today", |
Collaborator
There was a problem hiding this comment.
I think this change was not on purpose, can you remove?
clairep94
reviewed
Mar 7, 2026
| return <Loader />; | ||
| } else if (collections.length === 0) { | ||
| return t('AddToCollectionList.Empty'); | ||
| return <CollectionCreate />; |
Collaborator
There was a problem hiding this comment.
this change also seems to be outside of your described issue.
Can you put it on a separate PR if its helpful? Please include the before and after of the change on that PR
Contributor
Author
There was a problem hiding this comment.
Sure I will do This
clairep94
requested changes
Mar 7, 2026
clairep94
added
the
Contributor Follow-up Required
- Revert unintentional Sidebar.Title change in en-US translations - Revert out-of-scope AddToCollectionList.jsx change (CollectionCreate) - Fix dropdown menu text to use Collection.RemoveFromCollection key
SinhaS12
force-pushed
the
fix-ui-collections
branch
from
b388e1c to
d18f6fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3883
In the current Collection’s sketch list view, each sketch displays an “X” button. The purpose of this button is not immediately clear, which can cause confusion for users — it may appear as though it deletes the sketch entirely rather than simply removing it from the collection.
This pull request replaces the ambiguous “X” button with a dropdown actions menu to improve clarity, consistency, and overall user experience. The implementation follows the existing dropdown pattern used in other parts of the editor (e.g., My Sketches and My Collections pages).
Demo:
Replaced the “X” button with a dropdown menu trigger.
Added “Remove from Collection” as the first dropdown action.
Ensured consistent styling and behavior with other dropdown menus in the editor.
Changes:
Removed the “X” button from CollectionMetadata.jsx.
Integrated the dropdown actions menu following the pattern used in SketchListRowBase.jsx.
Implemented the “Remove from Collection” action within the dropdown.
Maintained visual consistency with existing UI components.
Ensured accessibility and keyboard interaction compatibility.
I have verified that this pull request:
has no linting errors (npm run lint)
has no test errors (npm run test)
has no typecheck errors (npm run typecheck)
is from a uniquely-named feature branch and is up to date with the develop branch.
is descriptively named and links to an issue number (Fixes #___).
meets the standards outlined in the accessibility guidelines.