fix: renamed test files to specify unit or integration tests in client#3992
Closed
kunstewi wants to merge 1 commit intoprocessing:developfrom
Closed
fix: renamed test files to specify unit or integration tests in client#3992kunstewi wants to merge 1 commit intoprocessing:developfrom
kunstewi wants to merge 1 commit intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Collaborator
|
Hi please see the reply in your original issue, thanks! Very open to your suggestions for tests improvements otherwise, or if you want to unit test any components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3993
NOTE: This is not a breaking change, I have made sure renaming these files don't have any side effects.
@clairep94 could you take a glimpse please?
Thanks a lot for your time.
Issue:
Many test files don't specify if they are unit or integration tests. That creates confusion for contributors and creates inconsistency throughout the project.
Fix
Renamed the test files to specify if they are unit or integration test:
My logic for renaming each test file:
client/common/Button.test.tsx- Reusable user-facing button variants (button, internal link, external link).client/common/ButtonOrLink.test.tsx- Reusable primitive that conditionally renders button/link and handles click/navigation behavior.client/common/IconButton.test.tsx- Reusable icon button behavior/props checks.client/common/RouterTab.test.tsx- Reusable tab link component behavior and router path change assertion.client/common/Tooltip.test.tsx- Reusable tooltip interaction states (hover/focus/visibility).client/common/useKeyDownHandlers.test.tsx- Hook-level keyboard handler behavior in isolation.client/common/useModalClose.test.tsx- Hook-level modal close behavior in isolation.client/common/usePrevious.test.tsx- Hook-level state transition behavior in isolation.client/common/useSyncFormTranslations.test.tsx- Hook-level form translation sync behavior in isolation.client/components/Dropdown/DropdownMenu.test.tsx- Reusable dropdown component behavior (open/select/close).client/components/Menubar/Menubar.test.tsx- Reusable menubar system behavior (keyboard, submenu, ARIA).client/components/PreviewNav.test.tsx- User-facing nav component rendering/interaction checks.client/components/SkipLink.test.tsx- User-facing accessibility control behavior.client/utils/consoleUtils.test.ts- Utility function outputs for parsing/offset logic.client/utils/device.test.ts- Utility function behavior for platform detection conditions.client/utils/dispatcher.test.ts- Utility module behavior (registerFrame,dispatchMessage, listeners).client/utils/evaluateExpression.test.ts- Utility function behavior and error handling in isolation.client/utils/formatDate.test.ts- Utility formatting behavior over controlled date inputs.client/utils/getConfig.test.ts- Utility config resolution behavior by environment shape.client/utils/language-utils.test.ts- Utility language resolution behavior from navigator inputs.client/utils/parseStringToType.test.ts- Utility parsing behavior for number/boolean conversion paths.client/utils/parseURLParams.test.ts- Utility URL parsing behavior over query param permutations.client/utils/reduxFormUtils.test.ts- Validation utility behavior for form input variants.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123