installer: replace init with version-aware router#285
Open
fischeti wants to merge 4 commits into
Open
Conversation
3 tasks
fischeti
force-pushed
the
fischeti/website
branch
from
741244c to
0041bc1
Compare
Contributor
Author
Yes, this is the best way to go I think |
micprog
approved these changes
Mar 26, 2026
Member
micprog
left a comment
micprog
left a comment
There was a problem hiding this comment.
LGTM 👍 Merging when we do the 0.32 release
Rename the old init script to init-legacy (unchanged) and introduce a thin version-aware router as the new init entry point. - Versions >= 0.31.0 (first cargo-dist release) and 'latest' are routed to the cargo-dist installer on GitHub Releases. - Older versions are delegated to init-legacy, preserving full backward compatibility including the sh -s -- VERSION interface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Rebased this to |
Flip the v0.32+ cargo-dist path to mirror legacy behavior by default (binary in CWD, PATH untouched) and introduce a `global` keyword that installs into $CARGO_HOME/bin — via cargo-dist's installer for v0.32+, or by relocating the legacy script's output for older versions. Update the installation guide and CI example accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The legacy installer fallback was hardcoded to pulp-platform.github.io, requiring fork-test setups to edit three places instead of one. Derive the Pages base from $REPO via parameter expansion so retargeting the script to a fork only requires updating the single $REPO variable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
@fischeti I updated the scripting to support the legacy flow and enable that as default, as well as enable global installs with a flag, including for legacy binaries. I haven't tested the script yet, but this well keep docs (e.g., worflows/ci) working. Let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the old
initscript toinit-legacy(unchanged) and introduce a thin version-aware router as the new init entry point.0.32.0(first cargo-dist release) andlatestare routed to the cargo-dist installer on GitHub Releases.init-legacy, preserving full backward compatibility including the sh -s -- VERSION interface.TODO
websitefolder onmasterwebsitebranch