-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement async support for open_datatree #10742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aladinor
wants to merge
43
commits into
pydata:main
Choose a base branch
from
aladinor:async-dtreec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+771
−37
Open
Changes from 41 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
9916b0b
adding async for datatrees
aladinor afa42e9
adding async method to _maybe_create_index
aladinor d469f2e
using async as complete instead of gathering results
aladinor d53498a
adding tests for open_group, open_dtree and _maybe_create_index using…
aladinor 3b26dd6
Merge branch 'main' into async-dtreec
aladinor b5ab48a
ensuing _maybe_create_default_indexes_async is compatible with zarr v2
aladinor 94a9efd
resolving the mypy type errors
aladinor 288a818
Merge branch 'async-dtreec' of https://github.com/aladinor/xarray int…
aladinor 573a700
attemp 2: resolving mypy type errors
aladinor 7557261
Merge branch 'main' into async-dtreec
aladinor 3c10a23
Merge branch 'main' into async-dtreec
aladinor 013804c
Merge branch 'main' into async-dtreec
aladinor f4ca679
Merge branch 'main' into async-dtreec
aladinor 531c589
refactor: consolidate async index creation for DataTree opening
aladinor 0ee2a73
perf: remove unnecessary semaphore from async datatree opening
aladinor 6d6cd1e
fix: add zarr v2 fallback for datatree opening
aladinor 640081b
Merge branch 'main' into async-dtreec
aladinor 0ee154e
updating whats-new.rst file
aladinor 542cad3
Merge branch 'async-dtreec' of https://github.com/aladinor/xarray int…
aladinor 31b50dc
fix: re-add semaphore to async datatree opening to prevent deadlocks
aladinor b6a3b27
Merge branch 'main' into async-dtreec
aladinor 6c4d9e4
Merge branch 'main' into async-dtreec
aladinor a711167
Merge branch 'main' into async-dtreec
aladinor 2127aa5
Merge branch 'main' into async-dtreec
aladinor 5c2f62c
Merge branch 'main' into async-dtreec
aladinor 3a698d2
Merge branch 'main' into async-dtreec
aladinor 2501b2a
refactor: use async index creation in sync open_datatree for zarr
aladinor c3ec77e
fix: add type ignore for mypy arg-type error in open_datatree_async
aladinor 9bf810e
fix: add type annotations and fix Windows path in test
aladinor 10e4756
fix: add type annotations to nested async functions for mypy
aladinor 6f97d9c
Merge branch 'main' into async-dtreec
aladinor fbf4617
refactor: remove public open_datatree_async API per review feedback
aladinor c53f0bd
Merge branch 'main' into async-dtreec
aladinor 5da5adc
refactor: convert _build_group_members to module-level helper function
aladinor 1debb7c
fix: add cast for mypy type checking in _build_group_members
aladinor 06bdab4
Merge branch 'main' into async-dtreec
keewis 480b872
Update xarray/backends/api.py
aladinor 02ee46b
refactor: use sync index creation in _maybe_create_default_indexes_async
aladinor b008620
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 422d127
Update xarray/backends/api.py
aladinor 179c20c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a4844b5
Update xarray/backends/api.py
aladinor b58ffb3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.