Fix env-var name for parallel tox tests#1112
Draft
meshy wants to merge 1 commit intopytest-dev:mainfrom
Draft
Conversation
When running tests in parallel, we need to add a suffix to Django DB names to avoid clashes. This previously used `TOX_PARALLEL_ENV`, but Tox no longer sets this environment variable. Tox does set an environment variable called `TOX_ENV_NAME`, which works for this purpose, so use that instead.
Contributor
Author
|
Oh dear, this broke more tests that I accounted for. |
Contributor
Author
|
I've just hit this again in a new project, and am glad I documented the workaround. It'd be nice to get this fixed here though. Perhaps someone could help me to understand where my solution went wrong here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tests in parallel, we need to add a suffix to Django DB names to avoid clashes. This previously used
TOX_PARALLEL_ENV, but Tox no longer sets this environment variable.Tox does set an environment variable called
TOX_ENV_NAME, which works for this purpose, so use that instead.I was able to get my local Tox tests running in parallel using this fixture, and it seemed as though the version in this repo should be updated.