Merged
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Removed commented-out code for check_scope_name_type function.
nicoddemus
reviewed
Apr 1, 2026
nicoddemus
reviewed
Apr 1, 2026
nicoddemus
reviewed
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #14137
Description
This PR addresses the type scope callable issue reported in #14137. We implemented the suggested fix from the issue thread by updating the type signature for the scope parameter. Specifically, we expanded the type hints to allow dynamic scope callables to return a standard str in addition to ScopeName.
Verification & Testing
To verify the fix, our team replicated the original issue and tested the changes locally in our virtual environment:
test.py) featuring a dynamic scope function (determine_my_client_scope) being passed to@pytest.fixture(scope=...).basedpyright test.pyagainst the unmodified repository successfully reproduced thereportArgumentTypeerror, complaining that a callable returningstrwas not assignable toScopeName | ((str, Config) -> ScopeName).basedpyright test.py. The type checker now passes cleanly with0 errors, 0 warnings, 0 notes.