feat: scan source distributions for compiled code#947
Open
tiran wants to merge 1 commit intopython-wheel-build:mainfrom
Open
feat: scan source distributions for compiled code#947tiran wants to merge 1 commit intopython-wheel-build:mainfrom
tiran wants to merge 1 commit intopython-wheel-build:mainfrom
Conversation
Member
LalatenduMohanty
requested changes
Mar 19, 2026
src/fromager/sources.py
Outdated
| build_env=build_env, | ||
| ) | ||
| # look for compiled code in sdist | ||
| scan_compiled_extensions(sdist_root_dir) |
Member
There was a problem hiding this comment.
@tiran Why not call it in prepare_new_source(), as this is a source validation step, not a build step.
Member
There was a problem hiding this comment.
We are ignoring the return value. IMO we should fail if we find pre-compiled code with an override in case we want to ignore the error.
LalatenduMohanty
requested changes
Mar 19, 2026
src/fromager/sources.py
Outdated
| build_env=build_env, | ||
| ) | ||
| # look for compiled code in sdist | ||
| scan_compiled_extensions(sdist_root_dir) |
Member
There was a problem hiding this comment.
We are ignoring the return value. IMO we should fail if we find pre-compiled code with an override in case we want to ignore the error.
LalatenduMohanty
requested changes
Mar 19, 2026
| ) | ||
| issues.append(filepath) | ||
| elif suffix not in ignore_suffixes: | ||
| with filepath.open("rb") as f: |
Member
There was a problem hiding this comment.
Wondering if we should put open() in a try/except for OSError to be resilient
src/fromager/sources.py
Outdated
| ".rs", | ||
| ".rst", | ||
| ".sh", | ||
| ".tml", |
Member
There was a problem hiding this comment.
Do you mean toml or html
The new helper function `scan_compiled_extensions` scans source distributions for compiled code. It detects common extensions like `.so` and `.dylib` as well as files with certain headers. The function is designed to detect packaging issues like sdists with pre-compiled code. It is incapable of detecting supply chain attacks and malicious code. Signed-off-by: Christian Heimes <cheimes@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new helper function
scan_compiled_extensionsscans source distributions for compiled code. It detects common extensions like.soand.dylibas well as files with certain headers.The function is designed to detect packaging issues like sdists with pre-compiled code. It is incapable of detecting supply chain attacks and malicious code.