Skip to content

bpo-36203: Check callback is callable in PyWeakref_NewRef#12244

Closed
tekknolagi wants to merge 0 commit into
python:mainfrom
tekknolagi:master
Closed

bpo-36203: Check callback is callable in PyWeakref_NewRef#12244
tekknolagi wants to merge 0 commit into
python:mainfrom
tekknolagi:master

Conversation

@tekknolagi

@tekknolagi tekknolagi commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

The documentation says that PyWeakref_NewRef should raise a
TypeError if the callback is not callable, None, or NULL, but the code
does not reflect the documentation. This PR fixes that.

This should probably be backported to whatever version of Python
changed that documentation.

https://bugs.python.org/issue36203

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@tekknolagi

Copy link
Copy Markdown
Contributor Author

Huh, weird. I definitely signed it earlier.

@iritkatriel

Copy link
Copy Markdown
Member

The patch needs tests.

@tekknolagi

Copy link
Copy Markdown
Contributor Author

Err, what? Why did it close?

@tekknolagi

Copy link
Copy Markdown
Contributor Author

Opened #26273 because I cannot reopen this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants