Skip to content

gh-143959: Split datetime tests requiring _datetime #143997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VanshAgarwal24036 wants to merge 10 commits into
base: main
Choose a base branch
from
+16 −7
Open

gh-143959: Split datetime tests requiring _datetime #143997

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df22dbc
gh-143959: Split datetime tests requiring _datetime
VanshAgarwal24036 Jan 18, 2026
3b42bcd
gh-143959: Split datetime tests requiring _datetime
VanshAgarwal24036 Jan 18, 2026
ecfbbbd
gh-143959: Skip datetime Fast tests when _datetime absent
VanshAgarwal24036 Jan 20, 2026
b227ee9
Removed whitespaces
VanshAgarwal24036 Jan 20, 2026
281077d
Correct Lint error
VanshAgarwal24036 Jan 20, 2026
9fafddb
gh-143959: Skip Fast datetime tests if _datetime is unavailable
VanshAgarwal24036 Jan 20, 2026
f21b5de
restore
VanshAgarwal24036 Jan 20, 2026
20b6944
Restore Changes
VanshAgarwal24036 Jan 21, 2026
b589068
Renamed Variable
VanshAgarwal24036 Jan 21, 2026
73a161a
Debug
VanshAgarwal24036 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions Lib/test/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,36 @@

from test.support.import_helper import import_fresh_module


TESTS = 'test.datetimetester'

def load_tests(loader, tests, pattern):
try:
pure_tests = import_fresh_module(TESTS,
fresh=['datetime', '_pydatetime', '_strptime'],
blocked=['_datetime'])
fast_tests = import_fresh_module(TESTS,
fresh=['datetime', '_strptime'],
blocked=['_pydatetime'])
try:
import _datetime
except ImportError:
has_datetime = False
Comment thread
VanshAgarwal24036 marked this conversation as resolved.
Outdated
else:
has_datetime = True
del _datetime
pure_tests = import_fresh_module(
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now restore the old formatting.

Copy link
Copy Markdown
Contributor Author

@VanshAgarwal24036 VanshAgarwal24036 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — I’ve restored the original formatting.

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not restored yet.

Copy link
Copy Markdown
Contributor Author

@VanshAgarwal24036 VanshAgarwal24036 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve now restored the original structure by keeping the two import_fresh_module() calls adjacent and moved the _datetime availability check outside that block.

TESTS,
fresh=['datetime', '_pydatetime', '_strptime'],
blocked=['_datetime'],
)
fast_tests = import_fresh_module(
TESTS,
fresh=['datetime', '_strptime'],
blocked=['_pydatetime'],
)
Comment thread
VanshAgarwal24036 marked this conversation as resolved.
Outdated
finally:
# XXX: import_fresh_module() is supposed to leave sys.module cache untouched,
# XXX: but it does not, so we have to cleanup ourselves.
for modname in ['datetime', '_datetime', '_strptime']:
for modname in ['datetime', '_datetime', '_pydatetime', '_strptime']:
sys.modules.pop(modname, None)

test_modules = [pure_tests, fast_tests]
test_suffixes = ["_Pure", "_Fast"]

# XXX(gb) First run all the _Pure tests, then all the _Fast tests. You might
# not believe this, but in spite of all the sys.modules trickery running a _Pure
# test last will leave a mix of pure and native datetime stuff lying around.
Expand All @@ -45,6 +56,9 @@ def load_tests(loader, tests, pattern):
class Wrapper(cls):
@classmethod
def setUpClass(cls_, module=module):
if module is fast_tests and not has_datetime:
raise unittest.SkipTest("requires _datetime module")

cls_._save_sys_modules = sys.modules.copy()
sys.modules[TESTS] = module
sys.modules['datetime'] = module.datetime_module
Expand Down
Loading