Skip to content

gh-145452: Initialize PyLazyImport_Type during interpreter startup #145453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 9 commits into from
Mar 3, 2026
Merged

gh-145452: Initialize PyLazyImport_Type during interpreter startup #145453

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
51ddfe7
Add failing test
johnslavik Mar 3, 2026
f90762a
Initialize `PyLazyImport_Type` in `_PyTypes_InitTypes`
johnslavik Mar 3, 2026
37e6257
Add explanations to the test
johnslavik Mar 3, 2026
1579fb9
Fix issue number in test explanation
johnslavik Mar 3, 2026
e498ab5
Use a descriptive docstring for the test
johnslavik Mar 3, 2026
ec6ed07
Use big boy guns for the subprocess test
johnslavik Mar 3, 2026
ee2d160
Add extra space line
johnslavik Mar 3, 2026
6ea42c7
Fix linting issue
johnslavik Mar 3, 2026
9cbc664
One more problem
johnslavik Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Lib/test/test_lazy_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,21 @@ def test_lazy_import_type_cant_construct(self):
"""LazyImportType should not be directly constructible."""
self.assertRaises(TypeError, types.LazyImportType, {}, "module")

@support.requires_subprocess()
def test_lazy_import_type_attributes_accessible(self):
"""Regression test for GH-145452."""
Comment thread
johnslavik marked this conversation as resolved.
Outdated
code = textwrap.dedent("""
lazy import json
print(globals()["json"].resolve)
""")
result = subprocess.run(
[sys.executable, "-c", code],
capture_output=True,
text=True
)
self.assertEqual(result.returncode, 0, f"stdout: {result.stdout}, stderr: {result.stderr}")
self.assertIn("<built-in method resolve of lazy_import object at", result.stdout)
Comment thread
johnslavik marked this conversation as resolved.
Outdated


class SyntaxRestrictionTests(unittest.TestCase):
"""Tests for syntax restrictions on lazy imports."""
Expand Down
2 changes: 2 additions & 0 deletions Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "pycore_instruction_sequence.h" // _PyInstructionSequence_Type
#include "pycore_interpframe.h" // _PyFrame_Stackbase()
#include "pycore_interpolation.h" // _PyInterpolation_Type
#include "pycore_lazyimportobject.h" // PyLazyImport_Type
#include "pycore_list.h" // _PyList_DebugMallocStats()
#include "pycore_long.h" // _PyLong_GetZero()
#include "pycore_memoryobject.h" // _PyManagedBuffer_Type
Expand Down Expand Up @@ -2540,6 +2541,7 @@ static PyTypeObject* static_types[] = {
&PyGen_Type,
&PyGetSetDescr_Type,
&PyInstanceMethod_Type,
&PyLazyImport_Type,
&PyListIter_Type,
&PyListRevIter_Type,
&PyList_Type,
Expand Down
Loading