Skip to content

gh-135953: Properly obtain main thread identifier in Gecko Collector #146045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flowln wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −7
Open

gh-135953: Properly obtain main thread identifier in Gecko Collector #146045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a82ac9
profiling(Gecko): Properly obtain main thread identifier
flowln Mar 17, 2026
8920f2f
profiling(gecko): take last thread as main thread instead of first one
flowln Mar 17, 2026
d9b0a79
profiling(Gecko): check if thread list is not empty before accessing it
flowln Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Lib/profiling/sampling/gecko_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,18 @@ def collect(self, stack_frames, timestamps_us=None):

# Process threads
for interpreter_info in stack_frames:
# Since 'threads' is in order from newest to oldest,
# we know the first thread must be the main thread.
main_tid = None
if len(interpreter_info.threads) != 0:
main_tid = interpreter_info.threads[-1].thread_id
for thread_info in interpreter_info.threads:
frames = filter_internal_frames(thread_info.frame_info)
tid = thread_info.thread_id

# Initialize thread if needed
if tid not in self.threads:
self.threads[tid] = self._create_thread(tid)
self.threads[tid] = self._create_thread(tid, main_tid)

thread_data = self.threads[tid]

Expand Down Expand Up @@ -288,14 +293,10 @@ def collect(self, stack_frames, timestamps_us=None):

self.sample_count += len(times)

def _create_thread(self, tid):
def _create_thread(self, tid, main_tid):
"""Create a new thread structure with processed profile format."""

# Determine if this is the main thread
try:
is_main = tid == threading.main_thread().ident
except (RuntimeError, AttributeError):
is_main = False
is_main = tid == main_tid

thread = {
"name": f"Thread-{tid}",
Expand Down
Loading