gh-146152: Fix memory leak in _json encoder error paths#146164
Open
okiemute04 wants to merge 3 commits intopython:mainfrom
Open
gh-146152: Fix memory leak in _json encoder error paths#146164okiemute04 wants to merge 3 commits intopython:mainfrom
okiemute04 wants to merge 3 commits intopython:mainfrom
Conversation
okiemute04
force-pushed
the
fix-json-encoder-leak
branch
3 times, most recently
from
3eddfdf to
51c39f9
Compare
Only clean up markers on the RecursionError path (PATH B), where objects accumulate during stack unwinding. Other error paths are safe because the markers dict is local and will be freed. Based on review feedback from @raminfp and @serhiy-storchaka.
okiemute04
force-pushed
the
fix-json-encoder-leak
branch
from
51c39f9 to
0597100
Compare
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I am not sure that this works. Please add a test.
- Define
default()which creates a new object, adds a weak reference to it to the list, and returns that object. - Call JSON encoding, and after catching an exception, call
test.support.gc_collect(), then test that all weak references in the list return None.
Contributor
Author
|
@serhiy-storchaka Thanks for the review! I've added a test to test_recursion.py that creates objects tracked with weak references, triggers a RecursionError, and verifies all objects are freed after garbage collection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146152
Add PyDict_DelItem calls to remove objects from the markers dict
on all error paths in encoder_listencode_obj. Previously, objects
were only removed on the success path, causing memory leaks when:
_json: stale markers entries on error paths inencoder_listencode_obj#146152