Fix type variable with values as a supertype#21431
Merged
ilevkivskyi merged 3 commits intopython:masterfrom May 7, 2026
Merged
Fix type variable with values as a supertype#21431ilevkivskyi merged 3 commits intopython:masterfrom
ilevkivskyi merged 3 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
May 7, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
This makes sense. It's odd that this didn't work in the past. I guess type variables with values are usually in the expanded form.
|
|
||
| # Cases specific w.r.t. right type are easier to handle before entering the SubtypeVisitor. | ||
| # Currently, these include Union types and TypeVarType with values. | ||
| if isinstance(right, TypeVarType) and right.values and not isinstance(left, TypeVarType): |
Collaborator
There was a problem hiding this comment.
Minor: what about moving this after the union type case, since this is likely much less common?
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21424
Unless I am missing something, this should be allowed.