Skip to content

Add missing attributes to json/decoder.pyi JSONDecoder #15333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b9788213 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add missing attributes to json/decoder.pyi JSONDecoder #15333

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d27cb71
Add missing attributes to json/decoder.pyi JSONDecoder
b9788213 Jan 28, 2026
aae4e27
.
b9788213 Jan 28, 2026
6087a97
.
b9788213 Jan 28, 2026
47fda0f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/json/decoder.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ class JSONDecoder:
parse_constant: Callable[[str], Any]
strict: bool
object_pairs_hook: Callable[[list[tuple[str, Any]]], Any]
parse_object: Callable[..., Any]
parse_array: Callable[..., Any]
parse_string: Callable[..., Any]
memo: dict[Any, Any]
Copy link
Copy Markdown
Collaborator

@srittau srittau Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but we should add the actual arguments and return types here. Same for the actual types in the memo dict. Alternatively, we could use Incomplete (from _typeshed) as a marker for now.

Copy link
Copy Markdown
Contributor Author

@b9788213 b9788213 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good way to tell they are the same thing, or have we copy the signature of the functions

Copy link
Copy Markdown
Collaborator

@srittau srittau Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copying the signature is fine where that makes sense.

Copy link
Copy Markdown
Contributor Author

@b9788213 b9788213 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSONArray and JSONObject wasnt exits so i tried implenting it but its so complex

def __init__(
self,
*,
Expand Down