Upgrade faiss to 1.14.2#2134
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR modernizes FAISS cuVS integration: migrate to ChangesFAISS cuVS Modernization Patches
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| @@ -1,182 +0,0 @@ | |||
| diff --git a/faiss/gpu/GpuDistance.cu b/faiss/gpu/GpuDistance.cu | |||
| index c82c73e7d..b9100c272 100644 | |||
| --- a/faiss/gpu/GpuDistance.cu | |||
There was a problem hiding this comment.
Why are we maintaining so many diffs? Can't we just use the most recent version?
There was a problem hiding this comment.
yes that is what I was thinking as well. @aamijar lets just maintain a single patch per release. The pinned faiss version is always fixed and the patch should be only tied to that and the current cuvs build.
| @@ -1,12 +1,25 @@ | |||
| diff --git a/faiss/gpu/utils/CuvsUtils.cu b/faiss/gpu/utils/CuvsUtils.cu | |||
There was a problem hiding this comment.
we'd probably want to rename the suffix to -cuvs-26.08.diff here for the current release.
Faiss has released v1.14.2 which includes an upgrade to cuVS 26.02. We can now remove the corresponding patches from cuvs and bump the faiss version that we are building against.