chore(orchestrator): remove janus-idp/cli and export-dynamic #2043
Conversation
Changed Packages
|
janus-idp/cli is being deprecated in favor of https://github.com/redhat-developer/rhdh-cli export-dynamic script is no longer necessary, and it is encouraged not to modify plugins to adapt dynamic plugins. Plugins can be exported as dynamic either by leveraging overlay repository or simply by executing npx @red-hat-developer-hub/cli Signed-off-by: Tomas Kral <[email protected]>
Signed-off-by: Tomas Kral <[email protected]>
kadel
force-pushed
the
orchestartor-rhdh-cli
branch
from
1ccd6d7 to
60f0a22
Compare
kadel
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
|
This will affect the PNC builds. Let's hope they will be no longer needed from the 1.9 on. |
|
@mareklibra Is that because they are using |
|
/hold |
Yes, please. |
|
Added back the export-dynamic scripts using Just note that there is still potential breaking change for frontend plugins. The new CLI does not use the --in-place flag as it is no longer needed. This means:
The plugin content itself remains the same, only the output directory has changed. This is the preferred method going forward. For example if pipeline is pushing package to NPM registry now you need to push package that is generated in |
kadel
force-pushed
the
orchestartor-rhdh-cli
branch
from
a51605e to
e22d768
Compare
|
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
Thank you for keeping the script.
Poor yarn.lock, it's growing and growing.
3 participants
janus-idp/cliis being deprecated in favor of https://github.com/redhat-developer/rhdh-cliexport-dynamicscript is no longer necessary, and it is encouraged not to modify plugins to adapt dynamic plugins.Plugins can be exported as dynamic either by leveraging overlay repository or simply by executing
npx @red-hat-developer-hub/clihttps://issues.redhat.com/browse/RHIDP-8531