-
Notifications
You must be signed in to change notification settings - Fork 212
chore: update marketplace wrapper to use extensions packages #3988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update marketplace wrapper to use extensions packages #3988
Conversation
d3fd114 to
a71feb9
Compare
|
/retest |
|
@karthikjeeyar the Hermetic build says: |
af0dda2 to
74c95ec
Compare
74c95ec to
46dab25
Compare
|
|
The image is available at: /test e2e-ocp-helm |
|
/retest |
1 similar comment
|
/retest |
ciiay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karthikjeeyar , code looks good to me, only left a small comment. Have tested it locally and verified it's working? It shows No plugins found on the Catalog tab for me. It could be a misconfiguration issue. As long as it works for you I'm good with merging this. Thank you 🤝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karthikjeeyar , shall we update L29-L32 too? Just to keep it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to keep the wrapper names and pluginId as it is for 1.9, so that we dont break any existing user installations. This will be removed in 1.10 when we switch over to OCI images for plugin installations, Until then the wrapper package name will be still red-hat-developer-hub-backstage-plugin-marketplace-*
No need for the legacy /marketplace for backward compatibility. This requires redhat-developer/rhdh#3988 to be merged. Co-authored-by: Gennady Azarenkov <[email protected]>
|
@ciiay Empty Catalog is due to metadata yamls has been moved to a new location (overlays repo) in 1.9, you can see there are more PRs linked to this PR which are needed to make this work again. Once this PR is merged then following PRs needs to be merged and then you will see the catalog again. You can manually import catalog entities via self service to test the extensions plugin - https://github.com/redhat-developer/rhdh-plugins/tree/main/workspaces/extensions/examples |
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dddd1e9
into
redhat-developer:main
…developer#3988) * update wrapper to use extensions package * update extensions import



Description
Update marketplace plugins to use new packages
backstage-plugin-extensions-*.Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-8299