Skip to content

Replacement for 'odo describe component'#5726

Open
vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-replace-odo-describe-component
Open

Replacement for 'odo describe component'#5726
vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-replace-odo-describe-component

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

@vrubezhny vrubezhny commented Apr 1, 2026

Fixes: #5747

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 76.48305% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.09%. Comparing base (da60441) to head (149f80c).
⚠️ Report is 1706 commits behind head on main.

Files with missing lines Patch % Lines
src/odo/util/describe.ts 79.40% 89 Missing and 1 partial ⚠️
...rc/webview/openshift-terminal/openShiftTerminal.ts 14.28% 18 Missing ⚠️
src/openshift/component.ts 81.81% 2 Missing ⚠️
src/odo/odoWrapper.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5726       +/-   ##
===========================================
+ Coverage   32.37%   46.09%   +13.72%     
===========================================
  Files          85      101       +16     
  Lines        6505     9309     +2804     
  Branches     1349     2090      +741     
===========================================
+ Hits         2106     4291     +2185     
- Misses       4399     5017      +618     
- Partials        0        1        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vrubezhny vrubezhny force-pushed the fix-replace-odo-describe-component branch from 04900ff to 0a34c5f Compare April 1, 2026 12:06
@vrubezhny vrubezhny marked this pull request as draft April 1, 2026 12:13
@vrubezhny vrubezhny force-pushed the fix-replace-odo-describe-component branch 8 times, most recently from 6e4638d to 036d916 Compare April 3, 2026 23:04
@vrubezhny vrubezhny mentioned this pull request Apr 9, 2026
11 tasks
@vrubezhny vrubezhny force-pushed the fix-replace-odo-describe-component branch from 036d916 to a9d300b Compare April 9, 2026 14:20
@vrubezhny vrubezhny linked an issue Apr 9, 2026 that may be closed by this pull request
@vrubezhny vrubezhny force-pushed the fix-replace-odo-describe-component branch 15 times, most recently from a00ce59 to d740cbe Compare April 14, 2026 12:23
@vrubezhny vrubezhny force-pushed the fix-replace-odo-describe-component branch 6 times, most recently from fea8281 to e9dfbd7 Compare April 15, 2026 14:10
@vrubezhny vrubezhny marked this pull request as ready for review April 15, 2026 22:01
@vrubezhny vrubezhny requested a review from rgrunber April 15, 2026 22:01
@rgrunber
Copy link
Copy Markdown
Member

rgrunber commented Apr 27, 2026

--- old.txt	2026-04-27 16:11:05.535535296 -0400
+++ new.txt	2026-04-27 16:21:15.117140720 -0400
@@ -5,11 +5,9 @@
 Version: 3.0.0
 Description: Stack with Node.js 18
 Tags: Node.js, Express, ubi8
+Schema Version: 2.2.0
 
-Running in: Dev
-
-Running on:
- •  cluster: Dev
+Running in: None
 
 Supported odo features:
  •  Dev: true
@@ -53,14 +51,20 @@
  •  deploy
       Type: composite
       Group: deploy
+      Commands: build-image, deployk8s
 
 Container components:
  •  runtime
     Source Mapping: /projects
+    Endpoints:
+      - http-node (3000)
+      - debug (5858)
 
 Kubernetes components:
  •  kubernetes-deploy
 
+Managed by: odo
+
 
+--- Close this terminal tab when finished ---
 
-Press any key to close this terminal

https://github.com/redhat-developer/vscode-openshift-tools/pull/5726/changes#diff-4720aba37279cdeadf2d5cb8f084ce05e1d514b9418fc89e41d841f8fd3307eeR205

This looks great to me. 👍 I did noticed the Managed by: odo line. Should that be there, especially when it should be removed ?

@vrubezhny
Copy link
Copy Markdown
Contributor Author

vrubezhny commented Apr 29, 2026

-Running in: Dev
-
-Running on:
- •  cluster: Dev
+Running in: None

It looks like at the moment you were executing Describe command on a component using the old version (with ODO) you were actually running your component in Dev...Otherwise the output here would be the same:

+Running in: None

Fixes: redhat-developer#5747

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Assisted-by: OpenAI ChatGPT
@vrubezhny vrubezhny force-pushed the fix-replace-odo-describe-component branch from e9dfbd7 to 149f80c Compare May 5, 2026 16:48
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out

  • adding a new workspace folder that contains a devfile (through mapFoldersToComponents )
  • creating a new component using a git repo that contains a devfile (through getExistingDevfile)

Seems to be working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacement for 'odo describe component'

2 participants