Skip to content

requirements: Remove line about selinux#1724

Merged
Feediver1 merged 2 commits into
mainfrom
stephna/remove-selinux-line
Jun 3, 2026
Merged

requirements: Remove line about selinux#1724
Feediver1 merged 2 commits into
mainfrom
stephna/remove-selinux-line

Conversation

@StephanDollberg
Copy link
Copy Markdown
Member

Some renewed throughput benchmarks show no measurable impact of selinux.

Remove it to avoid questions about it.

Description

Resolves https://redpandadata.atlassian.net/browse/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Some renewed throughput benchmarks show no measurable impact of selinux.

Remove it to avoid questions about it.
@StephanDollberg StephanDollberg requested a review from a team as a code owner June 2, 2026 15:47
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2026

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 553a5be
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/6a20608b1832ca0008060345
😎 Deploy Preview https://deploy-preview-1724--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f6b84b63-9a79-4974-ac3b-c216ef07f666

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR removes a warning from the Tuning section of the deployment requirements documentation. Previously, the section contained guidance noting that enabling SELinux may add performance overhead and recommending its disablement when not required. The change removes this two-line note, allowing the Tuning section to proceed directly from its introductory sentence to the conditional references for Kubernetes and non-Kubernetes tuning documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • redpanda-data/docs#1604: Previously added or moved SELinux performance-overhead guidance into the same Tuning section that this PR now removes it from.

Suggested reviewers

  • travisdowns
  • ballard26
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'requirements: Remove line about selinux' clearly and concisely describes the main change—removal of SELinux-related content from the requirements documentation.
Description check ✅ Passed The description provides rationale for the change (benchmark results showing no SELinux impact) and follows the template structure, but the JIRA ticket reference remains as a placeholder and no page previews were provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stephna/remove-selinux-line

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Feediver1 Feediver1 merged commit 8328cec into main Jun 3, 2026
7 checks passed
@Feediver1 Feediver1 deleted the stephna/remove-selinux-line branch June 3, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants