refac: pivot error page to show trace id, shorter message #8628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
approved these changes
Jan 14, 2026
Collaborator
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Just a small nit. Otherwise LGTM
| }); | ||
| } | ||
| function truncateMessage(message: string): string { |
Collaborator
There was a problem hiding this comment.
Why not use css directly for max width?
Member
Author
There was a problem hiding this comment.
CSS would work well with single line text for choose this option for multiline content. Using line-clamp could also be a bit tricky at places depending on the layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Pivot error page to
Mock layout
https://linear.app/rilldata/issue/APP-616/nicer-error-messages-in-pivot
Checklist: