feat(react-signals-transform): add native rolldown plugin#21
Open
JoviDeCroock wants to merge 2 commits intorolldown:mainfrom
Open
feat(react-signals-transform): add native rolldown plugin#21JoviDeCroock wants to merge 2 commits intorolldown:mainfrom
JoviDeCroock wants to merge 2 commits intorolldown:mainfrom
Conversation
Wrap the upstream Signals React Babel transform in a dedicated Rolldown plugin and port the transform and runtime tests so its behavior stays aligned with the original package.
Replace the Babel wrapper with a native Rolldown string transform and expand the ported test suite so the plugin behavior stays aligned with the upstream React Signals transform.
sapphi-red
reviewed
Mar 15, 2026
Member
sapphi-red
left a comment
There was a problem hiding this comment.
Do you want this plugin to live in this repo? I guess it'd be easier to maintain if it's colocated with the babel plugin.
Comment on lines
+1
to
+2
| /* oxlint-disable */ | ||
| // @ts-nocheck |
Member
There was a problem hiding this comment.
I guess you won't want these lines.
Author
|
@sapphi-red Happy to put it in the signals repository, was mainly thinking that it might be easier to find here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rolldown/plugin-react-signals-transformpackage for the React Signals transformprefreshportTesting
pnpm --filter @rolldown/plugin-react-signals-transform testpnpm --filter @rolldown/plugin-react-signals-transform buildpnpm exec oxlint --type-aware --type-check packages/react-signals-transformNote
This work was mainly done by GPT5.4 and reviewed by me