docs: upgrade insecure HTTP links to HTTPS in base core files#21602
docs: upgrade insecure HTTP links to HTTPS in base core files#21602aniruddhaadak80 wants to merge 2 commits intoroot-project:masterfrom
Conversation
Signed-off-by: Aniruddha Adak <aniruddhaadak80@users.noreply.github.com>
README.md
Outdated
|
|
||
| ## Live Demo for CERN Users | ||
| [](http://cern.ch/swanserver/cgi-bin/go?projurl=https://github.com/cernphsft/rootbinder.git) | ||
| [](https://swan.cern.ch/cgi-bin/go?projurl=https://github.com/cernphsft/rootbinder.git) |
There was a problem hiding this comment.
Did you verify this link? (It does not work for me, relevant or not this is from outside CERN).
There was a problem hiding this comment.
hey @pcanal , I have verified that the updated https URL actually 404s, so I have reverted that specific link inside README.md back to its original http cgi-bin routing endpoint.
The newly pushed commit reflects this fix. Thanks for catching that....
There was a problem hiding this comment.
Did you also hand verify all the other URLs? (If we are updating them, we must make sure they are up to date).
There was a problem hiding this comment.
Did you also hand verify all the other URLs? (If we are updating them, we must make sure they are up to date).
yes, i can confirm, that I verified all manually.
There was a problem hiding this comment.
Really? At least one of them does not lead to the intended place.
There was a problem hiding this comment.
See https://www.troll.no/qt/metaobjects.html which does not lead anywhere useful. To be accurate, the original is also broken. You may need to use the way back machine to get the original version and either find its 'new' home or link to the wayback machine.
…https version Signed-off-by: Aniruddha Adak <aniruddhaadak80@users.noreply.github.com>
|
FYI this person is most likely scatterblasting AI slop PRs and comments into many projects. |
4 participants
Description
Modernizes the core base headers by converting outdated
http://references (e.g., pcre, perl, rfc, swan) to securehttps://endpoints.Changes
core/base/inc/headers andREADME.mdto use HTTPS.