Skip to content

[webgui,net,graf] move builtins to subdir for consistency#22426

Merged
linev merged 3 commits into
root-project:masterfrom
ferdymercury:submisc
Jun 3, 2026
Merged

[webgui,net,graf] move builtins to subdir for consistency#22426
linev merged 3 commits into
root-project:masterfrom
ferdymercury:submisc

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

Spinoff of #21904 to easen review

@ferdymercury ferdymercury requested a review from bellenot as a code owner May 29, 2026 07:40
@ferdymercury ferdymercury requested a review from linev May 29, 2026 07:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Test Results

    22 files      22 suites   3d 11h 45m 17s ⏱️
 3 864 tests  3 864 ✅ 0 💤 0 ❌
77 139 runs  77 139 ✅ 0 💤 0 ❌

Results for commit 66b6820.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury changed the title [webgui] move builtins to subdir for consistency [webgui,net,graf] move builtins to subdir for consistency May 29, 2026
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Jun 2, 2026

Thanks for this work. While @linev and @bellenot have a look, let me perhaps note that it could be that at the moment we do not plan to have render core or mathjax on lcgweb by policy. This is due to the fact that we think to lcgweb as a place where the "easy" external packages can be added as backup, where "easy" means installable via the package managers of the linux distributions for which binaries are provided and Homebrew (which we consider the "macOS package manager").
Said that, thanks for these changes, they improve ROOT and provide clarity to its users and developers, kudos

Comment thread builtins/mathjax/CMakeLists.txt Outdated
Comment thread builtins/openui5/CMakeLists.txt Outdated
Comment thread builtins/rendercore/CMakeLists.txt Outdated
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Copy link
Copy Markdown
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it.

@linev linev merged commit 862d26f into root-project:master Jun 3, 2026
33 checks passed
@ferdymercury ferdymercury deleted the submisc branch June 3, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants