lifecycle_py: Add ament_mypy support

[mohit-swaran]

Description

This PR adds ament_mypy support and resolves type-checking errors in the lifecycle_py package

• Add test/test_mypy.py
• Used Dict[str, Any] in test_lifecycle.py for the generate_test_description() return type
• Resolved all mypy --strict errors found locally

Fixes (#768)

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information

[InvincibleRMC]

Looks good. Just small nits about using the modern typing syntax.

[mohit-swaran]

Understood! I will keep this in mind. Thank you for the catch!!

[InvincibleRMC]

Pulls: #778
Gist: https://gist.githubusercontent.com/InvincibleRMC/4077f59c7ce03b8028f616c2e41e910b/raw/6a2215cef572715b38436cdd1b8bdb4d088937ab/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies lifecycle_py
TEST args: --packages-above lifecycle_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18439

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[mohit-swaran]

lifecycle_py/talker.py: note: In member "__init__" of class "LifecycleTalker":
lifecycle_py/talker.py:38:50: error: "Unpack" is not supported by mypy yet

Looks like it is not supported with mypy 0.20.3 version? . What should I do about this ?

[InvincibleRMC]

You can probably add a # type: ignore since only rhel is affect since it is so.

[InvincibleRMC]

Pulls: #778
Gist: https://gist.githubusercontent.com/InvincibleRMC/5683309c62e93e177be70845c54b4c48/raw/6a2215cef572715b38436cdd1b8bdb4d088937ab/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies lifecycle_py
TEST args: --packages-above lifecycle_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18452

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[mohit-swaran]

Same error

2 errors
lifecycle_py/talker.py: note: In member "__init__" of class "LifecycleTalker":
lifecycle_py/talker.py:38:50: error: "Unpack" is not supported by mypy yet
Found 1 error in 1 file (checked 10 source files)

Should I change it to Any ?

[InvincibleRMC]

Your type ignore I believe has to be line with the code not above it. And I would make a generic one. not speficically about unused-ignore

[mohit-swaran]

Your type ignore I believe has to be line with the code not above it. And I would make a generic one. not speficically about unused-ignore

So is it okay to throw error unused-ignore in current version of mypy

talker.py:39: error: Unused "type: ignore" comment  [unused-ignore]
Found 1 error in 1 file (checked 2 source files)