use rosidl_runtime_c__String__assignn instead of memcpy.#455
Open
fujitatomoya wants to merge 1 commit intorollingfrom
Open
use rosidl_runtime_c__String__assignn instead of memcpy.#455fujitatomoya wants to merge 1 commit intorollingfrom
fujitatomoya wants to merge 1 commit intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Mar 13, 2026
Contributor
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
Replace manual memcpy-based string management with the standard rosidl_runtime_c__String__assignn API, which properly maintains capacity == size + 1.
Contributor
Author
|
with colcon test --event-handlers console_direct+ --packages-select rclc_parameterall tests are passing. |
Contributor
Author
|
Pulls: #455
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #454
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information