Skip to content

Make DEFAULT_INSTALL_EXTENSION_IN_LIB to false #9240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsbt wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −2
Open

Make DEFAULT_INSTALL_EXTENSION_IN_LIB to false #9240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48e5b46
Make DEFAULT_INSTALL_EXTENSION_IN_LIB false by default to stop instal…
hsbt Jan 9, 2026
69d72db
Initial plan
Copilot Jan 9, 2026
76c1929
Add assertion for install_extension_in_lib default value in test_init…
Copilot Jan 9, 2026
8eaf071
Merge pull request #9241 from ruby/copilot/sub-pr-9240
hsbt Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/rubygems/config_file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ class Gem::ConfigFile
DEFAULT_CONCURRENT_DOWNLOADS = 8
DEFAULT_CERT_EXPIRATION_LENGTH_DAYS = 365
DEFAULT_IPV4_FALLBACK_ENABLED = false
# TODO: Use false as default value for this option in RubyGems 4.0
DEFAULT_INSTALL_EXTENSION_IN_LIB = true
DEFAULT_INSTALL_EXTENSION_IN_LIB = false
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test in test_initialize doesn't verify the default value of install_extension_in_lib when no configuration is provided. Consider adding an assertion like assert_equal false, @cfg.install_extension_in_lib in the first part of the test_initialize method (around line 45) to explicitly test that the new default value is false when no config file setting overrides it.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@hsbt hsbt Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback


##
# For Ruby packagers to set configuration defaults. Set in
Expand Down
1 change: 1 addition & 0 deletions test/rubygems/test_gem_config_file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def test_initialize
assert_equal [@gem_repo], Gem.sources
assert_equal 365, @cfg.cert_expiration_length_days
assert_equal false, @cfg.ipv4_fallback_enabled
assert_equal false, @cfg.install_extension_in_lib

File.open @temp_conf, "w" do |fp|
fp.puts ":backtrace: true"
Expand Down